search

LNReader / lnreader

Light novel reader for Android.
https://lnreader.github.io
MIT License
1.6k stars 173 forks source link

DPI Issue #221

Open itsaaash opened 2 years ago

itsaaash commented 2 years ago

Screenshot_20220402-043610_LNReader Half the texts are hidden, doesn't get fixed until i lower or change the DPI. I'm on A12, the issue starts happening when I'm over 400+ DPI usually.

nyagami commented 1 year ago

image image Yes, I figured out why this bug happend. If title is too long (2+ lines), and the <Text> component will trunct the string (dont know why it trunct so damn). Should remove numberOfLines and use string.slice instead. 🤔 maybe 45 for max length

rajarsheechatterjee commented 1 year ago

Should remove numberOfLines and use string.slice instead. 🤔 maybe 45 for max length

I don't think slicing it would be the correct solutions as the text should take the available space in different resolutions.

nyagami commented 1 year ago

Yeah, but I think it's fine for almost cases. I chose 45 because on my emulator, 40 and 50 are limits which overflow string is still on one line with

rajarsheechatterjee commented 1 year ago

Yeah, but I think it's fine for almost cases. I chose 45 because on my emulator, 40 and 50 are limits which overflow string is still on one line with

Not for tablets or horizontal orientation.