search

LOD-GEOSS / databus-snippets

3 stars 1 forks source link

argument `user` ignored? #7

Closed giannou closed 2 years ago

giannou commented 2 years ago

What is the purpose of the user argument in this function? https://github.com/LOD-GEOSS/databus-snippets/blob/91bc01f1695e7d8040e895ce99e022dee9ca8146/dev_databus_api_example.py#L207

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented 2 years ago

Should replace the hard-coded "denis", no? https://github.com/LOD-GEOSS/databus-snippets/blob/91bc01f1695e7d8040e895ce99e022dee9ca8146/dev_databus_api_example.py#L233-L234

giannou commented 2 years ago

doesn't the function deploy_to_dev_databus definition end at line 218?

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented 2 years ago

Sure does :facepalm:

Next guess: deploy_to_dev_databus() was written by copying deploy_to_databus() and the user argument is useless.

yum-yab commented 2 years ago

Hi Guys, sorry for the confusion. @0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q is right, this is a useless parameter from copying the method. I fixed it in the new commit. The user is still needed bit is encoded in the objects (DataVersion,DataGroup) with the variable account_name (which should be set to your dev databus account name).

giannou commented 2 years ago

awesome thanks