Add Humble Support - Githubissues

LOEWE-emergenCITY / ros2_babel_fish

ROS2 communication introspection library to allow ROS2 communication with at compile time unknown message, action and service types.

MIT License

22 stars 8 forks source link

Add Humble Support #2

Closed genevanmeter closed 1 year ago

genevanmeter commented 2 years ago

Ref genevanmeter/ros2_babel_fish@3bf3e607ca54d0d8ca26bde15983c73bad84652c

Notes about my attempt to update to support humble.

Changes to get it to compile:

Explicitly include some headers.
Add ament_target_dependencies for some tests.
babel_fish_subscription.hpp/cpp: Added handle_serialized_message to compile but it doesn't do anything. Should it?
ros2_babel_fish/src/detail/babel_fishservice.cpp: Function signature for callback.dispatch has changed. I didn't understand how to handle so I commented it out for now.

StefanFabian commented 2 years ago

Thank you for the first look into this, I will have a deeper look into it but I'm not sure if I will be able to before August just as a heads up.

gavanderhoorn commented 1 year ago

I would also be very happy if Humble support could be added.

@StefanFabian would you have some time to look into this and perhaps provide some guidance?

StefanFabian commented 1 year ago

Hm, regarding services. Unfortunately, they changed the AnyServiceCallback dispatch so that you can't give it a response container anymore. I don't really understand why they removed that. I will submit a PR to add this as an optional parameter again since that is the only non-hacky way to support services.

Edit: Nevermind, as it currently is that wouldn't be enough and it looks like I can't get around creating my own AnyServiceCallback version.

StefanFabian commented 1 year ago

Builds and all tests pass in a humble docker container.

gavanderhoorn commented 1 year ago

Awesome. Thanks