search

LOEWE-emergenCITY / ros2_babel_fish

ROS2 communication introspection library to allow ROS2 communication with at compile time unknown message, action and service types.
MIT License
22 stars 8 forks source link

BabelFishSubscription: Subscription options not fully passed #6

Open aaron-jca opened 3 months ago

aaron-jca commented 3 months ago

Noticed that when constructing a BabelFishSubscription the option is passed, and the events are used. Here a new options is constructed and the option events are used

This unfortunately disallows the use of QoS overrides, and likely other things from the original options. Here's an article where QoS overrides are discussed.

aaron-jca commented 3 months ago

I also tried this with publishers and was unable to get them working. Could also be bugged there, but its also possible I had some syntax wrong... I was a bit rushed

StefanFabian commented 1 month ago

Sorry for the late reply. Not sure if I understand the issue correctly, I have changed this code slightly for jazzy and am doing basically the same as the normal templated Subscription. Does that fix the issue? I am open for PRs that address this issue for earlier versions :)