LOGUNIVPM / LOGinstruments

LOGinstruments: VCV Rack plugins by Leonardo Gabrielli
BSD 3-Clause "New" or "Revised" License
39 stars 3 forks source link

Your modules in Cardinal? #18

Open taji opened 6 months ago

taji commented 6 months ago

I use the excellent LessMess in VCV but am trying to port my projects to use Cardinal (https://cardinal.kx.studio/). However Cardinal requires a GPLv3+ compatible license (as described here under "Adding Modules": https://cardinal.kx.studio/modules). Is this something you would consider changing? Thanks :-)

LOGUNIVPM commented 6 months ago

Dear taji, Thanks for pointing this out. I'd be glad to see my modules adopted in Cardinal, provided that their appearance stays the same (I see Fundamental does not, but the other plugins seems to appear as they are in VCV). I see no problems in relaxing the current licence model to GPLv3+, however I have a couple of questions:

dromer commented 6 months ago

@LOGUNIVPM the BSD-3 software license is compatible, no worries (GPLv3+ would be restricting, comparatively).

The only thing we do like to have with Cardinal is the ability to have a "dark mode". Either you implement a dark theme for your modules, or we can do a trick for inverting/replacing certain colors on the Cardinal end (this is what we do for Mutable Instruments, and the reverse for Befaco, etc.)

For the VCV modules we had to resort to fully custom UI because we were not allowed to use their branding, which is embedded in the design.

taji commented 6 months ago

Is there anything else that needs to be done here to move this forward? If I can help I am glad to do so.

In the meantime, I've figured out a work around using the Stoermelder Glue module, the Polyphonic Split/Merge Modules and a blank panel:

image

LOGUNIVPM commented 6 months ago

I have quickly tested my modules with color inversion. I think it is ok for now if you simply invert the colors. In the future I may design a dark theme.

How do you implement the dark theme in Cardinal?

dromer commented 6 months ago

Dark themes now work the same as in VCV: https://vcvrack.com/manual/PluginGuide#Dark-panels (we used to have a custom implementation, before VCV created an API for this)

LOGUNIVPM commented 6 months ago

Ok. I'll inform you if in future I will add the dark panel option.