search

LOLINTERNETZ / vscodeoffline

Enables Visual Studio Code's extension gallery to be used in offline (air-gapped) environments. Or, run your own gallery!
https://hub.docker.com/u/lolinternet
MIT License
95 stars 28 forks source link

RSSH server file location #64

Open SpeedyH30 opened 3 months ago

SpeedyH30 commented 3 months ago

The server files that are downloaded into a remote server are hosted at update.visualstudio.com/commit://stable We have been manually downloading the files and hosting them at that location. any way to integrate them into this at all?

forky2 commented 1 month ago

vscodeoffline should already handle such URLs. If the commitid (which uniquely identifies the VS Code version) is found in the metadata, then the file "{platform}/{buildquality}" will be downloaded correctly.

However, if you're suffering from the same issue as me, it seems that as of recent versions of VS Code a new platform is being requested from the marketplace which is not being downloaded by vscodeoffline. I'm currently running 1.88.1, and when I attempt to connect to a linux host I get an error that the mirror returned 500. Which it does because the file being requested - commit:blah/cli-alpine-x64/stable - doesn't exist on the mirror. And that's because 'cli-alpine' isn't in the list of PLATFORMS to download.

I'm going to amend it and run some local tests. If it resolves the issue I'll submit a PR.

SpeedyH30 commented 1 month ago

well I didnt think that the collector was was actually downloading the RSSH server parts either. I'm manually grabbing those and putting them in the correct commit id locations that vscode expects to download them from.

you dont actually need the cli-alpine-x64/ if in your settings.json do "remote.SSH.useExecServer": false but I am importing them manually as well. they all live in the same location

forky2 commented 1 month ago

@SpeedyH30 Thanks for the info about the setting; I wasn't aware of that.

I can confirm that with my change (PR #65) I am able to get everything working for remote SSH again. The extensions, cli-alpine and the code server all download correctly from the vscodeoffline mirror; they are all integrated into vscodeoffline.

If you have the following A records point at your mirror it should work:

If this doesn't work for you, I'm not sure why.

LOLINTERNETZ commented 1 month ago

Thanks @forky2 PR #65 has been merged and is in 1.0.25. Thanks for the fix!

SpeedyH30 commented 1 month ago

Ahh in that case I shall raise a pr that includes all of the different rssh server variants

Cheers

SpeedyH30 commented 1 month ago

Just struggling to get it to grab the server-linux-x64-web It seems to skip over even looking for certain arch or build types regardless of having them set in the arch or buildtype list.