LOOHP / ImageFrame

Put images on maps and walls!
https://www.spigotmc.org/resources/106031/
GNU General Public License v3.0
40 stars 12 forks source link

Folia compat updates #37

Closed TechnicallyCoded closed 5 months ago

TechnicallyCoded commented 6 months ago

This PR is based on the code from the PR by HSGamer looking to fix one of the issues with ImageFrames on Folia ( #35 )

Looking for feedback on a few things. There are 2 parts to this:

I need input mainly for part 2, where I removed things without being 100% sure of the impact this would have to people using the animated frames. Is there a specific reason to cache frames that aren't attached to any plugin frame data? If so, is there another way to do this? This could possibly be hundreds of frames that don't need to be manually ticked that are ticking anyway.

Otherwise part 1 should be exactly equivalent except moved into another part of the class such that the one method is not so huge and easier to understand.

LOOHP commented 5 months ago

Thanks for the PR. I've been busy so it took some time for me to catch up. I don't quite remember why I added the two commented lines, I'll take a closer look in the future so I'll keep it for now, but the rest of the code looks good and seems to be working. Thank you!