LOOHP / ImageFrame

Put images on maps and walls!
https://www.spigotmc.org/resources/106031/
GNU General Public License v3.0
43 stars 12 forks source link

ImageFrame in Folia Swipe Error #65

Open HYDeath opened 1 month ago

HYDeath commented 1 month ago

ImageFrame installs into folia with an error. log: [10:32:18] [Folia Async Scheduler Thread #22139/ERROR]: Thread Folia Async Scheduler Thread #22139 failed main thread check: Accessing entity state off owning region's thread java.lang.Throwable: null at io.papermc.paper.util.TickThread.ensureTickThread(TickThread.java:78) ~[luminol-1.20.4.jar:git-Luminol-"d753f16"] at org.bukkit.craftbukkit.v1_20_R3.entity.CraftGlowItemFrame.getHandle(CraftGlowItemFrame.java:21) ~[luminol-1.20.4.jar:git-Luminol-"d753f16"] at org.bukkit.craftbukkit.v1_20_R3.entity.CraftGlowItemFrame.getHandle(CraftGlowItemFrame.java:6) ~[luminol-1.20.4.jar:git-Luminol-"d753f16"] at org.bukkit.craftbukkit.v1_20_R3.entity.CraftEntity.isInWorld(CraftEntity.java:944) ~[luminol-1.20.4.jar:git-Luminol-"d753f16"] at org.bukkit.craftbukkit.v1_20_R3.entity.CraftEntity.isValid(CraftEntity.java:398) ~[luminol-1.20.4.jar:git-Luminol-"d753f16"] at com.loohp.imageframe.objectholders.AnimatedFakeMapManager.lambda$collectItemFramesInfo$0(AnimatedFakeMapManager.java:100) ~[[I][地图画]ImageFrame-1.7.9.0.jar:?] at com.loohp.imageframe.objectholders.AnimatedFakeMapManager.collectItemFramesInfo(AnimatedFakeMapManager.java:121) ~[[I][地图画]ImageFrame-1.7.9.0.jar:?] at com.loohp.imageframe.objectholders.AnimatedFakeMapManager.run(AnimatedFakeMapManager.java:131) ~[[I][地图画]ImageFrame-1.7.9.0.jar:?] at com.loohp.imageframe.objectholders.Scheduler.lambda$runTaskTimerAsynchronously$12(Scheduler.java:168) ~[[I][地图画]ImageFrame-1.7.9.0.jar:?] at io.papermc.paper.threadedregions.scheduler.FoliaAsyncScheduler$AsyncScheduledTask.run(FoliaAsyncScheduler.java:217) ~[luminol-1.20.4.jar:?] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) ~[?:?] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) ~[?:?] at java.lang.Thread.run(Thread.java:1583) ~[?:?] [10:32:18] [Folia Async Scheduler Thread #22139/ERROR]: Thread Folia Async Scheduler Thread #22139 failed main thread check: Accessing entity state off owning region's thread java.lang.Throwable: null at io.papermc.paper.util.TickThread.ensureTickThread(TickThread.java:78) ~[luminol-1.20.4.jar:git-Luminol-"d753f16"] at org.bukkit.craftbukkit.v1_20_R3.entity.CraftGlowItemFrame.getHandle(CraftGlowItemFrame.java:21) ~[luminol-1.20.4.jar:git-Luminol-"d753f16"] at org.bukkit.craftbukkit.v1_20_R3.entity.CraftGlowItemFrame.getHandle(CraftGlowItemFrame.java:6) ~[luminol-1.20.4.jar:git-Luminol-"d753f16"] at org.bukkit.craftbukkit.v1_20_R3.entity.CraftEntity.isInWorld(CraftEntity.java:944) ~[luminol-1.20.4.jar:git-Luminol-"d753f16"] at org.bukkit.craftbukkit.v1_20_R3.entity.CraftEntity.isValid(CraftEntity.java:398) ~[luminol-1.20.4.jar:git-Luminol-"d753f16"] at com.loohp.imageframe.objectholders.AnimatedFakeMapManager.lambda$collectItemFramesInfo$0(AnimatedFakeMapManager.java:100) ~[[I][地图画]ImageFrame-1.7.9.0.jar:?] at com.loohp.imageframe.objectholders.AnimatedFakeMapManager.collectItemFramesInfo(AnimatedFakeMapManager.java:121) ~[[I][地图画]ImageFrame-1.7.9.0.jar:?] at com.loohp.imageframe.objectholders.AnimatedFakeMapManager.run(AnimatedFakeMapManager.java:131) ~[[I][地图画]ImageFrame-1.7.9.0.jar:?] at com.loohp.imageframe.objectholders.Scheduler.lambda$runTaskTimerAsynchronously$12(Scheduler.java:168) ~[[I][地图画]ImageFrame-1.7.9.0.jar:?] at io.papermc.paper.threadedregions.scheduler.FoliaAsyncScheduler$AsyncScheduledTask.run(FoliaAsyncScheduler.java:217) ~[luminol-1.20.4.jar:?] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) ~[?:?] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) ~[?:?] at java.lang.Thread.run(Thread.java:1583) ~[?:?]

milu2048 commented 1 month ago

I had the same problem, but I didn't seem to have any bugs other than hogging logs

LOOHP commented 1 month ago

Can you post the new stacktrace after updating to the latest dev build?

milu2048 commented 1 month ago

Use: ImageFrame-1.7.9.2.jar Log:

[17:20:01 ERROR]: Thread Folia Async Scheduler Thread #0 failed main thread check: Accessing entity state off owning region's thread
java.lang.Throwable: null
        at io.papermc.paper.util.TickThread.ensureTickThread(TickThread.java:78) ~[folia-1.20.6.jar:1.20.6-5-d797082]
        at org.bukkit.craftbukkit.entity.CraftItemFrame.getHandle(CraftItemFrame.java:169) ~[folia-1.20.6.jar:1.20.6-5-d797082]
        at org.bukkit.craftbukkit.entity.CraftItemFrame.getHandle(CraftItemFrame.java:14) ~[folia-1.20.6.jar:1.20.6-5-d797082]
        at org.bukkit.craftbukkit.entity.CraftEntity.isInWorld(CraftEntity.java:940) ~[folia-1.20.6.jar:1.20.6-5-d797082]
        at org.bukkit.craftbukkit.entity.CraftEntity.isValid(CraftEntity.java:394) ~[folia-1.20.6.jar:1.20.6-5-d797082]
        at 【图像帧】ImageFrame-1.7.9.2.jar/com.loohp.imageframe.objectholders.AnimatedFakeMapManager.lambda$collectItemFramesInfo$0(AnimatedFakeMapManager.java:100) ~[【图像帧】ImageFrame-1.7.9.2.jar:?]
        at 【图像帧】ImageFrame-1.7.9.2.jar/com.loohp.imageframe.objectholders.AnimatedFakeMapManager.collectItemFramesInfo(AnimatedFakeMapManager.java:121) ~[【图像帧】ImageFrame-1.7.9.2.jar:?]
        at 【图像帧】ImageFrame-1.7.9.2.jar/com.loohp.imageframe.objectholders.AnimatedFakeMapManager.run(AnimatedFakeMapManager.java:131) ~[【图像帧】ImageFrame-1.7.9.2.jar:?]
        at 【图像帧】ImageFrame-1.7.9.2.jar/com.loohp.imageframe.objectholders.Scheduler.lambda$runTaskTimerAsynchronously$12(Scheduler.java:168) ~[【图像帧】ImageFrame-1.7.9.2.jar:?]
        at io.papermc.paper.threadedregions.scheduler.FoliaAsyncScheduler$AsyncScheduledTask.run(FoliaAsyncScheduler.java:217) ~[folia-1.20.6.jar:?]
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) ~[?:?]
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) ~[?:?]
        at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]
HYDeath commented 1 month ago

Use: ImageFrame-1.7.9.2.jar Log:

[17:20:01 ERROR]: Thread Folia Async Scheduler Thread #0 failed main thread check: Accessing entity state off owning region's thread
java.lang.Throwable: null
        at io.papermc.paper.util.TickThread.ensureTickThread(TickThread.java:78) ~[folia-1.20.6.jar:1.20.6-5-d797082]
        at org.bukkit.craftbukkit.entity.CraftItemFrame.getHandle(CraftItemFrame.java:169) ~[folia-1.20.6.jar:1.20.6-5-d797082]
        at org.bukkit.craftbukkit.entity.CraftItemFrame.getHandle(CraftItemFrame.java:14) ~[folia-1.20.6.jar:1.20.6-5-d797082]
        at org.bukkit.craftbukkit.entity.CraftEntity.isInWorld(CraftEntity.java:940) ~[folia-1.20.6.jar:1.20.6-5-d797082]
        at org.bukkit.craftbukkit.entity.CraftEntity.isValid(CraftEntity.java:394) ~[folia-1.20.6.jar:1.20.6-5-d797082]
        at 【图像帧】ImageFrame-1.7.9.2.jar/com.loohp.imageframe.objectholders.AnimatedFakeMapManager.lambda$collectItemFramesInfo$0(AnimatedFakeMapManager.java:100) ~[【图像帧】ImageFrame-1.7.9.2.jar:?]
        at 【图像帧】ImageFrame-1.7.9.2.jar/com.loohp.imageframe.objectholders.AnimatedFakeMapManager.collectItemFramesInfo(AnimatedFakeMapManager.java:121) ~[【图像帧】ImageFrame-1.7.9.2.jar:?]
        at 【图像帧】ImageFrame-1.7.9.2.jar/com.loohp.imageframe.objectholders.AnimatedFakeMapManager.run(AnimatedFakeMapManager.java:131) ~[【图像帧】ImageFrame-1.7.9.2.jar:?]
        at 【图像帧】ImageFrame-1.7.9.2.jar/com.loohp.imageframe.objectholders.Scheduler.lambda$runTaskTimerAsynchronously$12(Scheduler.java:168) ~[【图像帧】ImageFrame-1.7.9.2.jar:?]
        at io.papermc.paper.threadedregions.scheduler.FoliaAsyncScheduler$AsyncScheduledTask.run(FoliaAsyncScheduler.java:217) ~[folia-1.20.6.jar:?]
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) ~[?:?]
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) ~[?:?]
        at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]

[01:33:45] [Folia Async Scheduler Thread #7/ERROR]: Thread Folia Async Scheduler Thread #7 failed main thread check: Accessing entity state off owning region's thread java.lang.Throwable: null at io.papermc.paper.util.TickThread.ensureTickThread(TickThread.java:78) ~[luminol-1.20.4.jar:git-Luminol-"9885fe4"] at org.bukkit.craftbukkit.v1_20_R3.entity.CraftItemFrame.getHandle(CraftItemFrame.java:169) ~[luminol-1.20.4.jar:git-Luminol-"9885fe4"] at org.bukkit.craftbukkit.v1_20_R3.entity.CraftItemFrame.getHandle(CraftItemFrame.java:14) ~[luminol-1.20.4.jar:git-Luminol-"9885fe4"] at org.bukkit.craftbukkit.v1_20_R3.entity.CraftEntity.isInWorld(CraftEntity.java:944) ~[luminol-1.20.4.jar:git-Luminol-"9885fe4"] at org.bukkit.craftbukkit.v1_20_R3.entity.CraftEntity.isValid(CraftEntity.java:398) ~[luminol-1.20.4.jar:git-Luminol-"9885fe4"] at com.loohp.imageframe.objectholders.AnimatedFakeMapManager.lambda$collectItemFramesInfo$0(AnimatedFakeMapManager.java:100) ~[[I][地图画]ImageFrame-1.7.9.2.jar:?] at com.loohp.imageframe.objectholders.AnimatedFakeMapManager.collectItemFramesInfo(AnimatedFakeMapManager.java:121) ~[[I][地图画]ImageFrame-1.7.9.2.jar:?] at com.loohp.imageframe.objectholders.AnimatedFakeMapManager.run(AnimatedFakeMapManager.java:131) ~[[I][地图画]ImageFrame-1.7.9.2.jar:?] at com.loohp.imageframe.objectholders.Scheduler.lambda$runTaskTimerAsynchronously$12(Scheduler.java:168) ~[[I][地图画]ImageFrame-1.7.9.2.jar:?] at io.papermc.paper.threadedregions.scheduler.FoliaAsyncScheduler$AsyncScheduledTask.run(FoliaAsyncScheduler.java:217) ~[luminol-1.20.4.jar:?] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) ~[?:?] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) ~[?:?] at java.lang.Thread.run(Thread.java:1583) ~[?:?] [01:33:45] [Folia Async Scheduler Thread #7/ERROR]: Thread Folia Async Scheduler Thread #7 failed main thread check: Accessing entity state off owning region's thread java.lang.Throwable: null at io.papermc.paper.util.TickThread.ensureTickThread(TickThread.java:78) ~[luminol-1.20.4.jar:git-Luminol-"9885fe4"] at org.bukkit.craftbukkit.v1_20_R3.entity.CraftItemFrame.getHandle(CraftItemFrame.java:169) ~[luminol-1.20.4.jar:git-Luminol-"9885fe4"] at org.bukkit.craftbukkit.v1_20_R3.entity.CraftItemFrame.getHandle(CraftItemFrame.java:14) ~[luminol-1.20.4.jar:git-Luminol-"9885fe4"] at org.bukkit.craftbukkit.v1_20_R3.entity.CraftEntity.isInWorld(CraftEntity.java:944) ~[luminol-1.20.4.jar:git-Luminol-"9885fe4"] at org.bukkit.craftbukkit.v1_20_R3.entity.CraftEntity.isValid(CraftEntity.java:398) ~[luminol-1.20.4.jar:git-Luminol-"9885fe4"] at com.loohp.imageframe.objectholders.AnimatedFakeMapManager.lambda$collectItemFramesInfo$0(AnimatedFakeMapManager.java:100) ~[[I][地图画]ImageFrame-1.7.9.2.jar:?] at com.loohp.imageframe.objectholders.AnimatedFakeMapManager.collectItemFramesInfo(AnimatedFakeMapManager.java:121) ~[[I][地图画]ImageFrame-1.7.9.2.jar:?] at com.loohp.imageframe.objectholders.AnimatedFakeMapManager.run(AnimatedFakeMapManager.java:131) ~[[I][地图画]ImageFrame-1.7.9.2.jar:?] at com.loohp.imageframe.objectholders.Scheduler.lambda$runTaskTimerAsynchronously$12(Scheduler.java:168) ~[[I][地图画]ImageFrame-1.7.9.2.jar:?] at io.papermc.paper.threadedregions.scheduler.FoliaAsyncScheduler$AsyncScheduledTask.run(FoliaAsyncScheduler.java:217) ~[luminol-1.20.4.jar:?] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) ~[?:?] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) ~[?:?] at java.lang.Thread.run(Thread.java:1583) ~[?:?]

LOOHP commented 3 weeks ago

Hi, did you set Settings.HandleAnimatedMapsOnMainThread to true in the config?

HYDeath commented 3 weeks ago

Hi, did you set Settings.HandleAnimatedMapsOnMainThread to true in the config?

NO, default configuration: false, I'll enable it later.