LORD-MicroStrain / microstrain_inertial

ROS driver for all of MicroStrain's current G and C series products. To learn more visit
https://www.microstrain.com/inertial
93 stars 67 forks source link

Config filename typo: `gx5_25.yml` vs `gx5_15.yml` #320

Closed GreatAlexander closed 2 months ago

GreatAlexander commented 3 months ago

Describe the bug Minor filename typo. Config file should be gx5_15.yml not gx5_25.yml in the gx5_15 folder (ros2 branch). https://github.com/LORD-MicroStrain/microstrain_inertial/blob/ros2/microstrain_inertial_examples/config/gx5_15/gx5_25.yml

To Reproduce Launch the gx5_15 example launch file which points to a non-existent file.

Expected behavior Example launch file works correctly

Environment (please complete the following information):

Additional context While setting up our own launch repo based on the examples, we noticed this naming inconsistency. Apologies if this is not the right process / we've missed something.

robbiefish commented 2 months ago

Thanks for pointing that out and making the PR. Just merged