search

LOST-STATS / lost-stats.github.io

Source code for the Library of Statistical Techniques
https://lost-stats.github.io/
GNU General Public License v2.0
263 stars 167 forks source link

Update to Other/import_a_foreign_data_file.md #194

Closed mcwayrm closed 1 year ago

mcwayrm commented 1 year ago

Made a small contribution to the R code commands in Other/import_a_foreign_data_file.md. rio is a general purpose package to import a variety of different file types smoothly.

NickCH-K commented 1 year ago

This looks good! I can't merge until the build and push passes, but I don't think that's to do with your work, rather a Ruby thing. I'll merge once that gets cleared up on our end.

mcwayrm commented 1 year ago

Got it! Should I wait to start on making edits on another page until this is resolved (then pull the updated repo)? Or should I continue to make pull requests despite not clearing the check?

NickCH-K commented 1 year ago

You can keep going, although we won't be able to merge anything until we resolve the Ruby issue.

mcwayrm commented 1 year ago

Made a contribution to Geo-Spatial/choropleths.md 906c76e. It looks like I can't open another pull request until the previous one is closed. So, I don't know if I should make another request after the merge (in the future) or if (since it has no conflicts with the upstream branch) it will automatically merge with the existing pull request.

NickCH-K commented 1 year ago

Alright! I think we have fixed the Ruby problem. Still getting a build error on your PR but I suspect it's a versioning issue. Can you try syncing your fork and re-pushing?

mcwayrm commented 1 year ago

Great!, I just did git pull upstream source and git push. Submitting the PR now. I didn't make any other edits. Hopefully this works. If not, I think I can recall the few changes I made and start with a fresh fork of the repo and try adding that in as a new PR.

mcwayrm commented 1 year ago

Most recent PR commit HEAD should be 759a46039b33388adf0666dbb2469cddfede8c8e

NickCH-K commented 1 year ago

Awesome! First new commit for a while, due to this Ruby thing.

mcwayrm commented 1 year ago

Great! Now that I know the commits will merge well I will try to make periodic/consistent additions. Hoping to maintain the stamina.