search

LOST-STATS / lost-stats.github.io

Source code for the Library of Statistical Techniques
https://lost-stats.github.io/
GNU General Public License v2.0
257 stars 166 forks source link

Added seaborn.objects line styling code to page needing more languages to it, #217

Closed RommelArtola closed 3 weeks ago

NickCH-K commented 3 weeks ago

This is great! Do you think you could drop the part about reassigning the year x-axis? We try to keep examples fairly short and focused on the task being described on the page.

RommelArtola commented 3 weeks ago

Certainly! I imagine you just mean in regards to the docstring, or the dataframe manipulation altogether?

If the former, absolutely. If the latter, definitely still possible but the xaxis just shows to ticks for two years (like 1980 and 2020, for example) out of the entire range. Couldn’t figure out how to add more xticks on it since it’s a date data type and not a numeric that can be achieved with so.Continous(), for example.

I can give it another shot after I’m home from work today again, and just have it show the default xticks if I can’t get it.

From: NickCH-K @.> Sent: Monday, August 19, 2024 10:53:31 PM To: LOST-STATS/lost-stats.github.io @.> Cc: Rommel Artola-Laiz @.>; Author @.> Subject: Re: [LOST-STATS/lost-stats.github.io] Added seaborn.objects line styling code to page needing more languages to it, (PR #217)

This is great! Do you think you could drop the part about reassigning the year x-axis? We try to keep examples fairly short and focused on the task being described on the page.

— Reply to this email directly, view it on GitHubhttps://github.com/LOST-STATS/lost-stats.github.io/pull/217#issuecomment-2298021890, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A5BSBEMBEM6BNP4SLRXJ5KDZSLKVXAVCNFSM6AAAAABMZB6Q2GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJYGAZDCOBZGA. You are receiving this because you authored the thread.Message ID: @.***>

RommelArtola commented 3 weeks ago

Dataframe is no longer aggregated and the xtick labeling for dates (temporal) was found and added

NickCH-K commented 3 weeks ago

Great, thank you! Sorry I didn't come to this sooner, I could have pointed you to so.Temporal() (IMO got a little fancy on the naming with this one, coulda just been Date)