search

LOVDnl / LOVD3

LOVD3 development repository
http://www.LOVD.nl
GNU General Public License v3.0
24 stars 4 forks source link

Feat/liftover existing variants #601

Open loeswerkman opened 2 years ago

loeswerkman commented 2 years ago

This code will identify existing variants that are not described on all active GBs, and add missing descriptions wherever possible by performing lift overs using VariantValidator.

Closes #600, related to #550.

loeswerkman commented 2 years ago

The code currently seems to work as I want it to. There is one problem still: the MAPPING_IN_PROGRESS flags that should be removed by the lovd_updateVariantsOnExit() shutdown function, are in fact not removed. As of yet I do not understand why not. I will look into this! Also, I will continue to test this code before the actual branch should be merged. However, for now the code should be good for a review.

--> Update 09/06: I have fixed the mapping_in_progress problem with the latest commit! The code has been tested quite extensively and, to me, is no longer a draft.