More fixes to the date fields in the GA4GH API and in form data processing. - Githubissues

LOVDnl / LOVD3

LOVD3 development repository

http://www.LOVD.nl

GNU General Public License v3.0

24 stars 4 forks source link

More fixes to the date fields in the GA4GH API and in form data processing. #635

Closed ifokkema closed 1 year ago

ifokkema commented 1 year ago

Date-related improvements.

More fixes to the date fields in the GA4GH API.

Consider 0-dates as no dates.
When there is no modification date, take the creation date.
Also add dates to variants within full submissions.
Fix tests.

Enforce correct dates entered through forms.

Improve lovd_matchDate() to enforce a valid date.
Clarify error messages, mention valid dates are needed.
Adjust lovd_matchDate() to optionally disallow 0-dates.
Force non-zero dates for created_date and edited_date during import.

Also:

Circumvent recurrent API issues with the HGNC that make the tests fail.