search

LPC-DM / decaf

1 stars 19 forks source link

BadECAL filter #14

Open mcremone opened 5 years ago

mcremone commented 5 years ago

Implement BadECAL filter from here: https://github.com/sidnarayanan/PandaAnalysis/search?q=cBadECALJets&unscoped_q=cBadECALJets

mcremone commented 5 years ago

Started here:

https://github.com/LPC-DM/decaf/blob/master/grinder/utils/corrections.py#L123-L128

this should retrieve the weight that is necessary to compute the filter as shown here:

https://github.com/sidnarayanan/PandaAnalysis/blob/0e411591911ae83dcbdc428496e7700445e844ae/Flat/src/JetsOps.cc#L214-L217

@trtomei would you mind finishing implementing it?

trtomei commented 5 years ago

Hi @mcremone

Yes, it is on my TODO list. I have time allocated for this tomorrow morning!

mcremone commented 5 years ago

thanks

trtomei commented 5 years ago

So, I have studied this a bit... this does not seem to be the filter described in: https://twiki.cern.ch/twiki/bin/viewauth/CMS/MissingETOptionalFiltersRun2#How_to_run_ecal_BadCalibReducedM

This seems to be some filter that filters events wholesale if jets coincide with some list of bad crystals or towers. I have found no hint of where is this list, and where does it come from. I suggest we acquire more information before going ahead with this.

mcremone commented 5 years ago

Following up the discussion on slack, I agree it would be good implementing something along the lines of what is implemented in https://github.com/TreeMaker/ecalBadCalibFilterLists/tree/master/data