search

LPGameDevs / EditarrrPublic

Public repo for level editor tools in Unity
MIT License
11 stars 2 forks source link

Backend: Level API Name/Code Filter Option #225

Closed HaywardMorihara closed 11 months ago

HaywardMorihara commented 11 months ago

https://github.com/LPGameDevs/EditarrrPublic/issues/224

Also, moved validation of filters to the "API layer" (rather than in the DB client) to be consistent with the rest of the validations

yanniboi commented 11 months ago

@HaywardMorihara One thing we MIGHT want to fix API side, but I can also do on the client:

If I dont pass in a large limit for level downloads it defaults to the default server limit and might not find a level if its not on the first page.

HaywardMorihara commented 11 months ago

@HaywardMorihara One thing we MIGHT want to fix API side, but I can also do on the client:

If I dont pass in a large limit for level downloads it defaults to the default server limit and might not find a level if its not on the first page.

You're absolutely right, my miss! I assumed the filtering would happen before the response is paged but I guess not. That's pretty annoying...

I'll follow this up with a fix

HaywardMorihara commented 10 months ago

@HaywardMorihara One thing we MIGHT want to fix API side, but I can also do on the client: If I dont pass in a large limit for level downloads it defaults to the default server limit and might not find a level if its not on the first page.

You're absolutely right, my miss! I assumed the filtering would happen before the response is paged but I guess not. That's pretty annoying...

I'll follow this up with a fix

@yanniboi working on the fix here: https://github.com/LPGameDevs/EditarrrPublic/issues/224