LPGhatguy / aftman

Aftman, the prodigal sequel to Foreman
MIT License
160 stars 18 forks source link

aftman does not mark binaries in tool-storage as executable on Unix systems #11

Closed osyrisrblx closed 2 years ago

osyrisrblx commented 2 years ago

image

I'm able to consistently reproduce this issue on Ubuntu WSL in Windows 11.

Text version ```sh ~/playgrounds/rbxts > rm -rf ~/.aftman/ ~/playgrounds/rbxts > aftman init ~/playgrounds/rbxts > aftman add rojo-rbx/rojo Tool rojo-rbx/rojo has never been installed before. Install it? yes [INFO aftman::tool_storage] Installing tool: rojo-rbx/rojo [INFO aftman::tool_storage] Downloading rojo-rbx/rojo v7.1.0 (rojo-7.1.0-linux.zip)... [INFO aftman::tool_storage] rojo-rbx/rojo v7.1.0 installed successfully. [INFO aftman::manifest] Tool rojo = rojo-rbx/rojo@7.1.0 has been added to /home/osyris/playgrounds/rbxts/aftman.toml ~/playgrounds/rbxts > rojo -V thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 13, kind: PermissionDenied, message: "Permission denied" }', src/tool_storage.rs:77:71 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ~/playgrounds/rbxts > chmod +x ~/.aftman/tool-storage/rojo-rbx/rojo/7.1.0/rojo ~/playgrounds/rbxts > rojo -V Rojo 7.1.0 ~/playgrounds/rbxts > ```
osyrisrblx commented 2 years ago

Found this 🙃

https://github.com/Roblox/foreman/blob/master/src/tool_cache.rs#L157-L163

LPGhatguy commented 2 years ago

Easy to fix! Will be tackled in the next release.