Improved error messages when Rosetta is not installed

LPGhatguy / aftman

Aftman, the prodigal sequel to Foreman

MIT License

157 stars 16 forks source link

Improved error messages when Rosetta is not installed #51

Open filiptibell opened 1 year ago

filiptibell commented 1 year ago

When running an executable built for x86 on an M1/M2 mac you will get this confusing error message if Rosetta is not installed: Bad CPU type in executable Since aftman will always pull x86 executables if a native one is not found for these machines (https://github.com/LPGhatguy/aftman/blob/main/src/tool_source/mod.rs#L36) it might be good for aftman to also be aware of rosetta and point users in the right direction if they don't have it installed.

LPGhatguy commented 4 months ago

I didn't realize that Rosetta was something that users had to install!

What do you think the best way to detect this failure mode is? I don't want Aftman to emit spurious warnings if we have any false-negatives trying to detect a Rosetta install. Should we bundle an x86-64 binary, try to run it, and see if it works?

jackTabsCode commented 3 months ago

Unless something has changed, I'm pretty sure that macOS "installs" Rosetta the moment the first x86 application is ran on the machine.