Use `rustls-tls` instead of `OpenSSL`

LPGhatguy / aftman

Aftman, the prodigal sequel to Foreman

MIT License

162 stars 19 forks source link

Use `rustls-tls` instead of `OpenSSL` #62

Closed DervexDev closed 7 months ago

DervexDev commented 7 months ago

Closes #61

LPGhatguy commented 7 months ago

Huh. I wonder why the 1.58 test suite has started failing, I noticed that on main too.

LPGhatguy commented 7 months ago

I bumped the MSRV on the main branch to 1.60.0. If you rebase or pull main, it'll rerun the test suite and we'll see.

DervexDev commented 7 months ago

Done!

DervexDev commented 7 months ago

Oh it failed again, looks like reqwest v0.11.27 requires rustc 1.63.0

LPGhatguy commented 7 months ago

Feel free to bump the MSRV in the workflow file until it does work 😅

DervexDev commented 7 months ago

Succeeded with 1.65.0

LPGhatguy commented 7 months ago

It looks like openssl is still ending up in the tree if you search in Cargo.lock. I think we need to set default-features = false as well in order to not use native TLS (and thus OpenSSL) on Linux.

You can compare this PR to jackTabsCode/asphalt#37 to see the difference.

DervexDev commented 7 months ago

It is actually not necessary to make Linux builds succeed but that's definitely better as we have less dependencies.

LPGhatguy commented 7 months ago

Right, not necessary to make the builds succeed, but it is necessary to ensure the binaries can run on machines that don't have a compatible version of OpenSSL installed. Otherwise, users would download and run the binary on those machines and find that they fail with a load-time error.