search

LPGhatguy / lemur

Partial implementation of Roblox API in Lua
MIT License
62 stars 25 forks source link

Yielding pcall - Closes #170 #172

Closed Kampfkarren closed 5 years ago

Kampfkarren commented 5 years ago

I have no idea what the consequences of something like this are; overriding a builtin as well as the way it was implemented.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.004%) to 97.984% when pulling 78bfe22d12c358677b24d86a70439962de2b2b0a on Kampfkarren:pcall into 363631e14b9059b629d7485249fbdbf41c3938a2 on LPGhatguy:master.

LPGhatguy commented 5 years ago

This implementation isn't correct -- yields go through pcall, they don't stop at pcall. We're going to need a lot more black magic than this in order to implement this in Lua I'm pretty sure.

Kampfkarren commented 5 years ago

Closing then.

Lua does have a page dedicated to getting this working, but I'm not sure if using a custom Lua implementation is reasonable (although it would allow for neat stuff like __namecall).