Replace naive implementation of Promise.is

LPGhatguy / roblox-lua-promise

(NO LONGER MAINTAINED) An implementation of promises akin to JavaScript's Promises/A+

Creative Commons Zero v1.0 Universal

23 stars 4 forks source link

Replace naive implementation of Promise.is #6

Closed Validark closed 6 years ago

Validark commented 6 years ago

Promise.is{_type = "Promise"} would previously return true, now it returns false
Added a weak hash table which holds a reference to each Promise as long as it still exists which can be used to check whether the object passed into Promise.is is an actual Promise.
Changed Promise.new variable promise to self, as that is what is used to refer to the promise elsewhere

LPGhatguy commented 6 years ago

Using a weak hash table is really unnecessary for checking the type of a promise. The improvement to be made there would be to use a userdata as a key!

I like the last change of changing the promise constructor variable to self a lot. I've been doing that in newer code.

LPGhatguy commented 6 years ago

I'm going to go ahead and close this for the same reasons that I talked about over on your other PR.

I'll also switch over the type marker to be a userdata, which I haven't done quite yet. That should help resolve the problem you identified here!