search

LPGhatguy / thunderdome

Arena type inspired by generational-arena
Apache License 2.0
197 stars 15 forks source link

Implement optional type for Index #39

Open tyler274 opened 1 year ago

tyler274 commented 1 year ago

Implementation of https://github.com/LPGhatguy/thunderdome/issues/16#issuecomment-1221442128

It passes all the tests, but I would highly suggest double checking I didn't mess up anything with the trait bounds on I littered all over the iters.

I also had to edit a lot of tests to be explicit about the Arena typing, and I'm not sure if its a breaking change backwards compatibility wise.

tyler274 commented 1 year ago

Removed the trait bounds mentioned, The tests still need some explicit type declaration though.

tyler274 commented 1 year ago

Implemented or derived Hash, PartialEq, and Eq

LPGhatguy commented 1 year ago

Hi, thanks for the PR!

This is really awesome. I wonder if there's anything we can do about the new inference issues.