search

LPardue / SpotifyStatusApplet

An LCD Applet for the Logitech Gaming keyboard family of devices
http://lucaspardue.com/spotifystatusapplet
Apache License 2.0
33 stars 7 forks source link

Added play/pause and track skip to buttons 2-4. #7

Closed JeffreyO closed 6 years ago

JeffreyO commented 6 years ago

I've 'fixed' the bug that crashes the program when an ad plays due to a NULL reference.

I also cleaned up your Visual Studio Project files and altered some things to make it more convenient and easier to build later on.

Enjoy!

LPardue commented 6 years ago

Thanks!

I'll take a closer look and hope to merge soon.

On 18 Jan 2018 00:19, "Jeffrey Ozanne" notifications@github.com wrote:

I've fixed the bug that crashes the program when an ad plays due to a NULL reference.

I also cleaned up your Visual Studio Project files and altered some tings to make it more convenient and easier to build later on.

Enjoy!

You can view, comment on, or merge this pull request online at:

https://github.com/LPardue/SpotifyStatusApplet/pull/7 Commit Summary

  • Added play/pause and track skip to buttons 2-4.

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/LPardue/SpotifyStatusApplet/pull/7, or mute the thread https://github.com/notifications/unsubscribe-auth/AGRFtW9Jpfm8UVifsxLVUALvVvQQ5gf7ks5tLo4FgaJpZM4RiMXL .

JeffreyO commented 6 years ago

Fixed the bug is a bit of a stretch. I've added a try-catch block temporarily so that the program doesn't crash (And so I get debug output when the exception is thrown.). It still throws the "System.NullReferenceException" exception during the ad, though it still runs rather than crashing. When the program picks up correct track data after the ad, it resumes normal operation as if nothing had happened.

I'm looking for a way to completely eliminate the exception from happening by checking to see if any of the needed values are NULL and substituting in a place-holder value. It should be commited once I have the issue taken care of.