search

LPeter1997 / CppCmb

A generic C++17 parser-combinator library with a natural grammar notation.
MIT License
122 stars 8 forks source link

Small fixes #2

Closed ColinH closed 5 years ago

LPeter1997 commented 5 years ago

Thank you for your contribution! I'm wondering if 

if (auto first = First()(it)) {
    return first;
}

Could also fix the TCO issue? Nice catch anyway!

ColinH commented 5 years ago

That's how i would have written it, but I didn't want to change your style.

(Btw, would you accept a patch to convert tabs to spaces?)

LPeter1997 commented 5 years ago

I am used to code with tabs in C++, but I am absolutely willing to consider switching to spaces if it's beneficial. I could see spaces solution for different tab sizes for example.