search

LPgenerator / mattermost_bot

MatterBot - A chat bot for MatterMost (http://www.mattermost.org).
MIT License
211 stars 60 forks source link

SSL_Verify false doesn't work #18

Closed tsmori closed 8 years ago

tsmori commented 8 years ago

I don't see anywhere in the code where the SSL_VERIFY variable is used and since python requests defaults to true, there isn't anyway to disable the verification.

gotlium commented 8 years ago

as argument here: https://github.com/LPgenerator/mattermost_bot/blob/master/mattermost_bot/bot.py#L27

as settings here: https://github.com/LPgenerator/mattermost_bot/blob/master/mattermost_bot/settings.py#L16

rewriting here: https://github.com/LPgenerator/mattermost_bot/blob/master/mattermost_bot/settings.py#L36

MATTERMOST_BOT_SSL_VERIFY=False - environment variable will be disable ssl verification or on settings SSL_VERIFY = False

@pschmitt can explain more information about ssl verification

pauvos commented 8 years ago

Can confirm that environment variable MATTERMOST_BOT_SSL_VERIFY=False does not disable SSL verification.

[07/12/2016 12:24:08] Starting new HTTPS connection (1): team.chefkoch.net
[...]
requests.exceptions.SSLError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:590)
tsmori commented 8 years ago

I discovered that the pip install didn't get all the latest bits of the project. The mattermost.py and bot.py files didn't have the SSL components. I grabbed all the latest files and the SSL_VERIFY in the settings.py file do work now.

Tim

On Tue, Jul 12, 2016 at 8:27 AM, Paul Voss notifications@github.com wrote:

Can confirm that environment variable MATTERMOST_BOT_SSL_VERIFY=False does not disable SSL verification.

[07/12/2016 12:24:08] Starting new HTTPS connection (1): team.chefkoch.net [...] requests.exceptions.SSLError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:590)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/LPgenerator/mattermost_bot/issues/18#issuecomment-232032319, or mute the thread https://github.com/notifications/unsubscribe/ATUeL0jPXBt_nwEViSAJ7ox1_IZ49Lvmks5qU4hKgaJpZM4JJnJR .

gotlium commented 8 years ago

Version with ssl verification was released to PyPi.