LPgenerator / mattermost_bot

MatterBot - A chat bot for MatterMost (http://www.mattermost.org).
MIT License
211 stars 60 forks source link

Mattermost moving to API version 4 #35

Open jasonblais opened 7 years ago

jasonblais commented 7 years ago

Those who are following this thread:

@attzonko helped create a new repo from this project with APIv4 support: https://github.com/attzonko/mmpy_bot

Would love to have you contribute and share feedback on how the bot is working!


Hey @gotlium !

First, hugely appreciate you sharing this project back with the world. Fantastic work!

I wanted to let you know about our plans moving to API v4:

To make the Mattermost API web service easier to use and to offer more powerful options for these integrations, Mattermost will be moving to a new API version soon. Highlights include:

We plan to release API version 4 on March 16th, with Mattermost server 3.7. While the current API version 3 will be supported until September 16th, we recommend you begin using API version 4 soon after its release.

Contributing

API version 4 is an active and on-going project. If you're interested in helping contribute, please join our Mattermost community instance and the APIv4 channel.

We've prepared a contribution process for APIv4 and a progress tracker for new APIv4 enpoints to help you get started.

We're also open for suggestions on adding new API endpoints to help with your integration.

attzonko commented 7 years ago

I am also very interested if there are plans to update this bot for API version 4. I would be willing to help with some guidance :)

gotlium commented 7 years ago

Hi, Thanks. I think it's a good idea to migrate to new documented API.

diegoroccia commented 7 years ago

Hi in the meanwhile , does this work with mattermost 3.9 ?

attzonko commented 7 years ago

I am running 3.10 and have no issue with this bot. Mattermost is still supporting the older API.

I guess eventually this code would need to be migrated to API V4 but for now it still seems to work.

SoundGoof commented 7 years ago

it seems to be a deadline now...

All APIv3 endpoints are scheduled for removal on January 16, 2018. https://docs.mattermost.com/administration/changelog.html#release-v4-1-0

gotlium commented 7 years ago

Hi, unfortunately I quit from this company and no longer supporting this app.

jasonblais commented 6 years ago

@gotlium Who is supporting this app now, do you know?

gotlium commented 6 years ago

Hi, I don't known. Possible we need to search new contributors.

jasonblais commented 6 years ago

Thanks @gotlium for the quick response!

@attzonko You previously signalled interest helping update this bot to API v4? Would you still be interested?

attzonko commented 6 years ago

@jasonblais Absolutely. It is sitting on my TODO list :)

jasonblais commented 6 years ago

@attzonko Great! You've also signed up at https://pre-release.mattermost.com, correct? If you have any questions, don't hesitate to ask the community or our staff there as well.

Curious what kind of a timeline would you have in mind for the migration? I'm sure you have lots of other items on your todo list :)

gotlium commented 6 years ago

When app will be migrate to API v4 and PR, I can release it to PyPi.

jasonblais commented 6 years ago

Perfect. Thanks @gotlium!

attzonko commented 6 years ago

@jasonblais Yes I am in the pre-release chat rooms. Now that I put 2 and 2 together and know which Jason this is I can bug you on there. As far as the time frame, it depends. the deadline was Jan 17, but existing instances should continue working as is correct? If my assumption is correct, my goal is to make incremental progress through Jan. When I initially looked at it, there was not too many APIs being used, so it could be fairly quick.

jasonblais commented 6 years ago

Perfect. And that's correct, existing instances will continue to work as usual.

attzonko commented 6 years ago

@gotlium @jasonblais I created a PR #55 which adds APIv4 support as well as a few of the other features from @seLain with tweaks/fixes from myself.

jasonblais commented 6 years ago

This is awesome. Thank you for the quick turnaround!

attzonko commented 6 years ago

@jasonblais The main reason for the quick turnaround is that @seLain had already done most of the work back in September.

jasonblais commented 6 years ago

@gotlium Would you have thoughts on the best way to transfer ownership of https://pypi.python.org/pypi/mattermost_bot?

@attzonko is open to assuming ownership of the repo and/or forking it for now.

//cc @deniskabalkin

jasonblais commented 6 years ago

Those who are following this thread:

@attzonko helped create a new repo from this project with APIv4 support: https://github.com/attzonko/mmpy_bot

Would love to have you contribute and share feedback on how the bot is working!