search

LPology / Simple-Ajax-Uploader

Javascript file upload plugin with progress bar support. Works in all major browsers, including IE7+, Chrome, Firefox, Safari, and Opera. No dependencies - use it with or without jQuery.
995 stars 267 forks source link

Cannot install using bower #138

Closed enumag closed 8 years ago

enumag commented 8 years ago

I'm unable to install this package using bower because there are no tags in this repository. Can you fix it?

enumag commented 8 years ago

And npm for some reason thinks that 2.2.4 is the latest version of this package. https://www.npmjs.com/package/simple-ajax-uploader

LPology commented 8 years ago

@enumag What needs to be fixed with tags? I'm not very experienced with bower.

Also, I'm not sure why it's showing 2.2.4 in npm, or how to fix it. Do you know what needs to be done to update it?

enumag commented 8 years ago

Well the tags need to exist in the first place. Currently there are none. https://github.com/LPology/Simple-Ajax-Uploader/tags You just need to create and push them. If you're not familiar with git tags I can explain how they work.

As for NPM there is a wrong URL to the git repository. It seems the package was created by @ruanyl so maybe he can fix it? And maybe it also requires tags to exist.

ruanyl commented 8 years ago

Hi, I updated the npm package to the latest release. But I think the idea thing is both bower and npm packages are maintained by the repo maintainers. I created that npm package because I didn't find the package on npm and for some reason, I have to use npm to manage the depens.

@enumag npm read the information from package.json, I will make a pull request to update the information.

LPology commented 8 years ago

@enumag I merged the pull request from @ruanyl to fix the package.json version number and URL. I also updated bower.json to use the full 2.4.0 version number.

Also, I created a tag for 2.4.0 and pushed it. @enumag , thanks for the info about git tags. I wasn't familiar with them before now, but I did some research and will begin using them now.

Does this fix everything for this issue?

enumag commented 8 years ago

I believe so. I'll reopen this if I run into any problems. Thanks. :-)

By the way you might also check out github releases feature. It's a great place for changelog.

enumag commented 8 years ago

Ok so bower unfortunately still doesn't work. The bower package is not linked to this repository but to a fork.

@jenkinliang Can you unregister your package from bower so that @LPology can register it himself properly?

enumag commented 8 years ago

@LPology Let's give him a week or so to reply. If he doesn't we can open a request in bower/registry.

LPology commented 8 years ago

@enumag That works for me. Thanks for following up.

enumag commented 8 years ago

@LPology @ruanyl It works now. Thank you both for cooperation!