search

LR-POR / PorGram

A Portuguese HPSG Grammar
Other
2 stars 1 forks source link

organizing and cleaning up files #76

Closed arademaker closed 2 years ago

arademaker commented 2 years ago
  1. [x] choices. Is this file different from the ones in https://github.com/LR-POR/PorGram/tree/main/grammar_choices? Can we move it to the folder?
  2. [x] matrix-br-eng.txt can we move it for the test folder?
  3. [x] my-test_sentences.txt same, can we move to test folder?
  4. [x] out.stats, out.txt and results.txt should be versioned?
leoalenc commented 2 years ago

Besides the tasks above, the goal of this issue is to organize the files of the repository in a more transparent way, renaming and merging files, moving files to different folders and removing deprecated, useless files.

leoalenc commented 2 years ago

https://github.com/LR-POR/PorGram/commit/1df6505dd686c89e409b288af9ca3c92e228cbde solves these tasks:

  1. [x] choices. Is this file different from the ones in https://github.com/LR-POR/PorGram/tree/main/grammar_choices? Can we move it to the folder?

This folder contained different versions of the choices file, which can be tracked with the commit history. So this folder was deleted.

  1. [x] matrix-br-eng.txt can we move it for the test folder?

Done.

  1. [x] my-test_sentences.txt same, can we move to test folder?

Done.

  1. [x] out.stats, out.txt and results.txt should be versioned?

These files were moved to test.

leoalenc commented 2 years ago

@arademaker, to conclude and close the issue, should we move all lexicon files to a lexicon folder? If you think so, how to specify the path in the lisp script? There is one problem with this solution: lexicon.tdl is generated by the Grammar Matrix system, which puts this file in the main folder of the grammar.

arademaker commented 2 years ago

Eu posso adaptar o lkb/script depois que vc mover os arquivos de entradas lexicais para o folder "lexicon".

Sugiro adotarmos alguma uniformidade nos nomes dos arquivos com entradas lexicais.

Sugiro mantemos o lexicon.tdl gerado pelo matrix no raiz e mantê-lo minimal, apenas com as entradas que forma colocadas no matrix para exemplificar instâncias de tipos.

Faça a mudança e submeta PR do branch para o master que eu adapto o lkb/script e faço o merge fechando este issue.

arademaker commented 2 years ago

O arquivo random-sample-204-entries.tdl tem apenas entradas lexicais mas foi deixado no raiz, alguma razão ?

arademaker commented 2 years ago

No commit 2369c34, ajustei o my-script, removi o my-globals.lsp atualizando o globals.lsp (experimentando evitar my-XX desnecessários).

arademaker commented 2 years ago

Outro arquivo de lexico 'sobrando' no raiz é o my-test-lexicon.tdl.. colocar no folder lexicon? remover?

leoalenc commented 2 years ago

O arquivo random-sample-204-entries.tdl tem apenas entradas lexicais mas foi deixado no raiz, alguma razão ?

Resolvido com https://github.com/LR-POR/PorGram/commit/b55ec46f066bbb928487677b326134897e9b9232.

arademaker commented 2 years ago

para fechar este issue, falta apenas mover o my-test-lexicon.tdl