Debugging, refactoring and documenting evaluate.lisp

LR-POR / cl-conllu

tool for working with conllu files in CL

Apache License 2.0

13 stars 5 forks source link

Debugging, refactoring and documenting evaluate.lisp #47

Closed GPPassos closed 6 years ago

GPPassos commented 6 years ago

Some modifications are:

ignore-punct (formerly just punct) key argument now correctly implemented in sentence-diff(what matters is only the original tag)
.*-average-score are now general scoring functions accepting any combination of fields.
attachment-score-.* are built on .*-average-score functions
recall, precision and confusion-matrix are working again
projectivitity-.*now correctly renamed to non-projectivity-.*

GPPassos commented 6 years ago

Hey @arademaker could you please take a look? Thanks! : )

arademaker commented 6 years ago

@GPPassos vou aceitar porque estou sem tempo de fazer code review. Também acho que code review via github meio complicado. No futuro, além de docstrings , gostaria de ver mais test cases. Temos que pensar nisso, talvez um mini-corpus em um subdiretório data/?