search

LRFLEW / OpenRCT2Launcher

An Open Source Launcher & Updater for OpenRCT2
MIT License
200 stars 20 forks source link

Launcher has to be edited to make users able to download x64/64-bit builds #20

Closed mrtnptrs closed 7 years ago

mrtnptrs commented 8 years ago

Just a reminder for when the 64-bit builds are fully ready and build automaticly by AppVeyor. Maybe let the launcher find if the user is using a 32-bit or 64-bit OS and choose and ALSO make an option to let the user choose if he wants the 32 or 64-bit builds? (just like we do now with choosing branches.) What does @LRFLEW think about this?

LRFLEW commented 8 years ago

@mrtnptrs Keep in mind that I don't get the builds from AppVeyor, but from OpenRCT2.org. When the 64-bit builds start up, I'll contact Jarno and see about getting the API updated for it.

I'm not sure if it's been decided that there will be separate 32-bit and 64-bit builds. It's likely that the project will distribute just one or the other. If there are two different builds, then I'll have two different builds of the launcher as well, and will most likely tie the version downloaded to the version of the launcher. I can probably figure out if it's a 64-bit system at runtime, though.

However, this is not an issue yet. We'll see when it happens.

GingerAdonis commented 8 years ago

API shouldn't need much of an update if there will be separate builds. It'll simply be a different flavourId than the one currently used for 32-bit.

Margen67 commented 7 years ago

64 bit builds are available now. https://openrct2.org/downloads/develop/latest

IntelOrca commented 7 years ago

Bump, they are now recommended as default download.

LRFLEW commented 7 years ago

Really? I think it's odd that you're making it the default, but ok.

@IntelOrca Are you planning on continuing supporting 32-bit or switch to 64-bit only in the near future?

IntelOrca commented 7 years ago

Continue to support 32-bit, you should check if the OS is 64-bit and use appropriate build

mrtnptrs commented 7 years ago

@IntelOrca But isn't it odd to recommend the 64-bit builds now, as much of the drawing code isn't done yet? Edit: sorry, clicked the wrong button.

LRFLEW commented 7 years ago

@mrtnptrs https://www.reddit.com/r/rct/comments/57nsez/openrct2_no_longer_uses_any_code_from_the/

LRFLEW commented 7 years ago

@IntelOrca

you should check if the OS is 64-bit and use appropriate build

I plan on going a separate route. Instead, I'll provide two versions of the launcher, one 32-bit and one 64-bit. I'll have the 32-bit launcher download the 32-bit game, and vice versa. It's easier for me, and allows for both to match.

Margen67 commented 7 years ago

Can this be closed now?

LRFLEW commented 7 years ago

Yeah, I need to go through and close the issues v0.0.6 fixed. I'll start with this one. 😄