search

LRFLEW / OpenRCT2Launcher

An Open Source Launcher & Updater for OpenRCT2
MIT License
200 stars 20 forks source link

Launcher fails to untar long paths #66

Open SpaceManiac opened 2 years ago

SpaceManiac commented 2 years ago

Having the problem on 64-bit Linux. OpenRCT2-0.3.5.1-develop-2b0d4e6-linux-x86_64.tar.gz contains some files:

OpenRCT2/data/object/rct2tt/footpath_railings/
OpenRCT2/data/object/rct2tt/footpath_railings/rct2tt.footpath_railings.medieval.parkobj
OpenRCT2/data/object/rct2tt/footpath_railings/rct2tt.footpath_railings.balustrade.parkobj
OpenRCT2/data/object/rct2tt/footpath_railings/rct2tt.footpath_railings.pavement.parkobj
OpenRCT2/data/object/rct2tt/footpath_railings/rct2tt.footpath_railings.circuitboard.parkobj
OpenRCT2/data/object/rct2tt/footpath_railings/rct2tt.footpath_railings.rocky.parkobj
OpenRCT2/data/object/official/footpath_surface/openrct2.footpath_surface.queue_invisible.json
OpenRCT2/data/object/rct2tt/footpath_railings/rct2tt.footpath_railings.circuitboard_invisible.parkobj
OpenRCT2/data/object/rct2tt/footpath_railings/rct2tt.footpath_railings.rainbow.parkobj

Instead of circuitboard_invisible, the launcher sees a file named ././@LongLink with type 'L' and bails in tarextractor.cpp because it does not know how to handle that type.

May be related to #63?

LRFLEW commented 2 years ago

Not really related in terms what code causes it, but should have the same solution: use an archive library. I am working on this, but getting everything working is taking some time.

While Linux is technically supported with the launcher, it's generally preferred to use your distro's package manager system (eg. with the PPA or AUR) since I can't guarantee how the pre-made builds will work with every distro's dependency builds. It might be worth checking to see what's available to you, at least in the short term while I work on getting this fixed.

janisozaur commented 2 years ago

Heads up: in working on extending our CI matrix with multi-distro builds, they will eventually get pushed to .org, see https://github.com/OpenRCT2/OpenRCT2/pull/16382

SpaceManiac commented 2 years ago

I'm on Ubuntu 18.04 Bionic which the PPA doesn't keep up-to-date anymore. Manually untarring the generic Linux binary used by the launcher has been working in the meantime.

janisozaur commented 2 years ago

@SpaceManiac we're dropping obsolete distributions soon, see https://github.com/OpenRCT2/OpenRCT2/issues/15501

SpaceManiac commented 2 years ago

18.04 is not officially obsolete until April 2023, but given that you said you "would rather drop old systems than language versions" I will support myself rather than argue about it