LRFLEW / OpenRCT2Launcher

An Open Source Launcher & Updater for OpenRCT2
MIT License
200 stars 20 forks source link

Invalid Download #68

Open FlightMS opened 1 year ago

FlightMS commented 1 year ago

I've tried to download the newest version of OpenRCT2, but after the download seems to be completed, I get a "Invalid Download" error

Screenshot 2022-12-14 210007

useranon404 commented 1 year ago

Has there been any resolution to this issue? I've been having the same problem. I disabled the firewall, but it still happens.

orffen commented 1 year ago

I've got the same issue, only with the Release build. Develop build is downloading fine.

orffen commented 1 year ago

I think this is caused by the OpenRCT2 website. The Release download page has the Windows builds duplicated, with 2 different file hashes. The launcher doesn't seem to handle this and so is likely failing the file hash check.

guillaumecardon commented 1 year ago

Issue still persist. Any fix possible ? This repository is dead ?

kereis commented 1 year ago

I think this is caused by the OpenRCT2 website. The Release download page has the Windows builds duplicated, with 2 different file hashes. The launcher doesn't seem to handle this and so is likely failing the file hash check.

The OpenRCT2.org REST API server returns wrong file hashes and file sizes to the launcher, causing the launcher to throw "Invalid Download Size" and "Invalid Download Hash" errors.

The problem might be related to this issue https://github.com/Limetric/OpenRCT2.org/issues/296. This could be probably fixed when this issue is resolved.


I don't think there's a proper way of handling this. You can get the file size by using GitHub's REST API. Regarding file hashes, besides OpenRCT2.org's REST API, there's no real way of fetching the corresponding file hash as a source of truth. This has to be fixed either in the OpenRCT2.org REST API, or the community should consider adding file hashes to the releases' file assets on GitHub.

EDIT: Some other suggestions that crossed my mind:

mrleblanc101 commented 1 year ago

The release version has "Invalid download", but the Development version doesn't throw error but the download never start and the Play button stay disabled.