Added spacers - Githubissues

LRFLEW / OpenRCT2Launcher

An Open Source Launcher & Updater for OpenRCT2

MIT License

200 stars 20 forks source link

Added spacers #9

Closed runelaenen closed 8 years ago

runelaenen commented 8 years ago

Added spacers to create a nicer layout

LRFLEW commented 8 years ago

This is a good idea. I have two comments about it though.

From what I saw testing this, 15 seems a bit large (particularly on OS X with its rounded buttons). 10 looked to be the best to me.
This really should be done using the margins of the containing layout. From my testing, a left & right margin of 10 and an up & down margin of 5 looked good on every OS I tested (OS X, Windows, Ubuntu, and Debian (the last of which the up & down margin actually does something))

LRFLEW commented 8 years ago

I ended up implementing this using margins instead. It looks better in the editor and requires less object spawning, making it cleaner. Thank your for the feedback, though.

runelaenen commented 8 years ago

You're welcome. I didn't know that was an option. I've never worked with the Qt editor before :)