LRP-sgravel / reframe360XL

Apache License 2.0
52 stars 8 forks source link

Black bars appear as circles at zenith and nadir #5

Open lanzz opened 2 years ago

lanzz commented 2 years ago

I have a project in a 16:9 aspect (e.g. 1920x1080) and a 2:1 clip from an Insta360 camera (5760x2880). Due to the different aspect ratios between the project and the clip, opening the 360 clip in Resolve leaves black bars at the top and bottom. When I apply the Reframe360XL effect on that clip, those black bars remain visible as black circles at zenith and nadir. If I zoom the 360 clip in a bit to get rid of the black bars in the unmapped view, the black circles in the reframed view disappear as well, but then the sides of my 360 clip are cut off in the unmapped view, which destroys the stitching after reframing. The only way to get seamless 360 video with no holes at zenith and nadir seems to be to make sure my entire project is produced in a 2:1 aspect, which is far from ideal for publishing.

Screen recording

DaVinci Resolve 18.0.1 build 3 Reframe360XL v1.0.Mac.beta (https://github.com/LRP-sgravel/reframe360XL/commit/9b9879482c6350244831bcb15c814f856fed62cb); I've also tried the bundle ZIP from the head of master (https://github.com/LRP-sgravel/reframe360XL/commit/870f6f56b7384dcba61e4aef2b817fa297e5e3e1) because there was a later commit about "fixing a black dot in center", but it still has these circles macOS 12.4, M1 Pro CPU

lanzz commented 2 years ago

Figured out how to work around this — if I adjust the vertical zoom independently from the horizontal zoom factor (by unchecking the link icon between them in the transform pane of the inspector), I can stretch the 360 clip to fill the entire frame, which gets rid of the black circles in the reframed view. To get the exact scaling factor, calculate (clip aspect ratio) / (project aspect ratio), e.g. for a 2:1 clip in a 16:9 project that would be (2/1) / (16/9) = 2 / 1.7777… = 1.125, so setting the Y zoom factor to 1.125 will expand it precisely the amount necessary to fill the frame.

It would still be nice if the plugin could apply this logic automatically.

p0las commented 1 year ago

thanks for the solution.