Closed fmeirinhos closed 1 year ago
Patch coverage: 97.08%
and project coverage change: +3.84%
:tada:
Comparison is base (
57e5027
) 82.84% compared to head (c37f9c8
) 86.68%. Report is 2 commits behind head on master.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
In the same line, the code was adjusted to increase the QoL:
bins
can be given as an int
, a list
of int
s, e.g., for 2-D, [50, 50]
. Arrays can be specified for each dimension, i.e., [np.array, np.array]
powers
has been simplified, such that simply an int
with the maximum power can be given, e.g., power=8
.Various tests were augmented
Adds some slight simplifications and removes an unnecessary normalization of the kernel inside the internal computations of
_km
.In essence, the pdf (zero-th power of
km
) was not being properly normalized anyway so this normalization was doing nada.If you think the pdf should come out normalized, I suggest adding a normalization flag in
km
and doing that there. I also added a flag for the user to control whether it outputs the bin edges or the bin centers.