galibhassan commented 4 years ago

Addressing Issue #5

LRydin commented 4 years ago

Nice! Give me a bit to check if everything is okay (should totally be). We should also add a small note on the docs saying that "FA can be achieved by simply taking order=0" (in better words than these :) )

codecov-commenter commented 4 years ago

Codecov Report

Merging #6 into master will decrease coverage by 2.31%. The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
- Coverage   78.18%   75.86%   -2.32%     
==========================================
  Files           4        4              
  Lines          55       58       +3     
==========================================
+ Hits           43       44       +1     
- Misses         12       14       +2

Impacted Files	Coverage Δ
MFDFA/MFDFA.py	`86.20% <71.42%> (-6.11%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0869737...2c38d0c. Read the comment docs.

galibhassan commented 4 years ago

Wondering why codecoverage checks are not passing. Possibily because I added the "kind of" tests in the ./tester.py. Just discovered we also have a test/test_MFDFA.py. Maybe codecoverage service is checking only the latter one and finding no tests for the if order==0.

LRydin commented 4 years ago

I will merge this so we can deal with the tests and documentation.

LRydin / MFDFA

Skip detrending if order==0 #6

Codecov Report