LSCOIT / LegalNavigator

Phase 3 Access2Justice continued
Creative Commons Attribution 4.0 International
9 stars 3 forks source link

Fixing icons & topic ordering & replacement LUIS with SPOT #1000

Open yevhenobertas opened 4 years ago

yevhenobertas commented 4 years ago

Fixing icons & topic ordering & replacement LUIS with SPOT

KellyeDC-zz commented 4 years ago

Verified. Ready for PO review.

grawdon commented 4 years ago

We are getting multiple listing for Topics again. I am seeing this for Hawaii. Maybe this will be corrected as part of the clean up going on now and once the spreadsheets are updated. And we won't know about the ordering until the states can do the rankings. image

grawdon commented 4 years ago

Also, the same organization is showing up multiple times with the same info: image

grawdon commented 4 years ago

@KellyeDC-zz @yevhenobertas @asaperski-gloriumtech The topic ordering still seems to be alpha, not in ranking order. image

ozholob commented 4 years ago

Hi @grawdon it's fixed on DEV as well. However, there is a case when it will work alphabetically. For example, if all resources have ranking=1. In this case, it works alphabetically. In fact, if you specify ordering like: Child and Family Service - Maui: ranking = 1 Child and Family Service - Molokai: ranking = 2 The ordering will work as expected.

Please let me know if you have any troubles with that, Thanks!

KellyeDC commented 4 years ago

@ozholob Was this issue resolved or did it appear that most of the resources were defaulted to rank at "1", which resulted in alphabetical order?

ozholob commented 4 years ago

Hi @KellyeDC this issue was resolved. You are right, in this case, resources have rank "1", and resulted in alphabetical order. So if you want to order by ranking, we need to make sure, each resource has its own unique ranking within the topic.

svasylenko commented 4 years ago

Tested on: Housing->Housing Assistance and Subsidized Housing. Orgs are ranked the same in file hence sorted alphabetically on portal. @svasylenko needs to ping Alex Forger to go through that.