gdal bindings deprecated in pip release

[fclubb]

• lsdviztools version: 0.4.4
• Python version: 3.9.1
• gdal version: 3.2.1
• Operating System: Ubuntu

Description

When importing the pip version of lsdviztools, there is an error with importing gdal.

This is because of lsdmap_vectortools;

import gdal as gdal

gdal > 3.1 does not accept this and it needs to be changed to from osgeo import gdal e.g. https://gdal.org/api/python.html

This is updated in the development version but not the pip release.

What I Did

import lsdviztools.lsdmapwrappers as lsdmw

Error:

---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
<ipython-input-6-af674bb898c5> in <module>
      5 # import lsdviztools.lsdbasemaptools as bmt
      6 # from lsdviztools.lsdplottingtools import lsdmap_gdalio as gio
----> 7 import lsdviztools.lsdmapwrappers as lsdmw
      8 # import lsdttparamselector as ps

~/miniconda3/envs/valley-width/lib/python3.9/site-packages/lsdviztools/lsdmapwrappers/__init__.py in <module>
      8 from __future__ import absolute_import, division, print_function, unicode_literals
      9 
---> 10 from .lsdmapwrappers_basicplotting import *
     11 from .lsdmapwrappers_chiplotting import *
     12 from .lsdmapwrappers_lsdttcli import *

~/miniconda3/envs/valley-width/lib/python3.9/site-packages/lsdviztools/lsdmapwrappers/lsdmapwrappers_basicplotting.py in <module>
     31 
     32 """
---> 33 from lsdviztools.lsdplottingtools import lsdmap_pointtools as LSDP
     34 from lsdviztools.lsdplottingtools import lsdmap_vectortools as LSDV
     35 from lsdviztools.lsdmapfigure.plottingraster import MapFigure

~/miniconda3/envs/valley-width/lib/python3.9/site-packages/lsdviztools/lsdplottingtools/__init__.py in <module>
     12 from .lsdmap_basicmanipulation import *
     13 from .lsdmap_pointtools import *
---> 14 from .lsdmap_chiplotting import *
     15 from .lsdmap_saplotting import *
     16 from .lsdmap_subplots import *

~/miniconda3/envs/valley-width/lib/python3.9/site-packages/lsdviztools/lsdplottingtools/lsdmap_chiplotting.py in <module>
     28 from lsdviztools.lsdplottingtools import init_plotting_DV
     29 from lsdviztools.lsdplottingtools import adjust_text
---> 30 from lsdviztools.lsdplottingtools import lsdmap_vectortools as LSDP
     31 from lsdviztools.lsdplottingtools import lsdmap_pointtools as PointTools
     32 from lsdviztools.lsdmapfigure import plottinghelpers as Helper

~/miniconda3/envs/valley-width/lib/python3.9/site-packages/lsdviztools/lsdplottingtools/lsdmap_vectortools.py in <module>
     15 from osgeo import ogr, osr
     16 from lsdviztools import lsdplottingtools as LSDPT
---> 17 import gdal as gdal
     18 from osgeo.gdalconst import GA_ReadOnly
     19 from lsdviztools.lsdmapfigure import plottinghelpers as Helper

ModuleNotFoundError: No module named 'gdal'

[simon-m-mudd]

Fixed as of lsdviztools version 0.4.6