Normalize all the line endings

LSLEditor / LSLEditorCE

Alphons van der Heijden, author of LSLEditor, the great off-line editor and debugging tool for scripting in Second Life, has donated his opus magnum to the free and open source community where it can grow and keep pace with the SL platform!

7 stars 6 forks source link

Normalize all the line endings #17

Closed jojorne closed 6 years ago

jojorne commented 6 years ago

Ok... So all the sudden my repo was giving me "all the files are modified" with no diff at all. It turns out that after you add ".gitattributes" you need to normalize all the line endings...

https://help.github.com/articles/dealing-with-line-endings/

Also ".gitignore" is really outdated. So I took the liberty to update it with Visual Studio's default one and it works! The "obj" folder is not included anymore nor the ".vs" folder.

PS.: "lsl-editor-doc.xml" is on ".gitignore" but also included inside the repo, why? Should I remove it from the the repo or the ".gitignore"?

jojorne commented 6 years ago

Ah! And this "All checks have failed" error is because you switched to ".Net Core" instead of "Mono" inside the ".travis.yml".

niel commented 6 years ago

That "All checks have failed" isn't because of the ".Net Core" Inside the yaml, it's because the checks failed :-) They fail whether it's set to Mono or .NET Core, because the test environment doesn't have some of the dependencies (none of the Windows specific stuff mostly). Unfortunately, the only way around that is to remove the dependencies (or turn off the checks entirely). This is what I said previously about having to get the CI working. I think for the short term I'm going to give up on that and just disable Travis. I've been looking around for alternatives, but can't find anything that doesn't either require a Windows server, or have recurring fees.

niel commented 6 years ago

Looking into the line endings :-( I may have been on Linux for too long and forgotten the hassles of dealing with Windows :-)

jojorne commented 6 years ago

Uh... Testing here:

dotnet build: I got same error on my end (error MSB3644). .Net 3.5 is not supported by Microsoft.
Switching the project to .Net 4.5 and... warning CS0168: "e" never used on "trunk\lsleditor.csproj". - I know this one, I can fix it. CSC : error CS1508: Identifier already used "Resources.resx" and "Unknown.gif" on "trunk\lsleditor.csproj". - No idea about this one yet.

niel commented 6 years ago

Those .gitignore additions look excessive. Can't you just ignore the entire directory tree where the building is done, instead of specifying every file type that might occur?

EDIT: Forget I asked that. Looked closer and you do have directories excluded in places. I wish I couldn't believe Windows apps produce so much crap outside of their own directories, but I do.

jojorne commented 6 years ago

Uh, I could try to remove some but I don't know exactly which one. You could change it after the merge tho. But I'm curious about the "dotnet build" on ".Net 4.5", it works!