LSPosed / LSParanoid

String obfuscator for Android applications
Apache License 2.0
291 stars 28 forks source link

Question: is this based on Paranoid library? #1

Closed AndroidDeveloperLB closed 1 year ago

AndroidDeveloperLB commented 1 year ago

This: https://github.com/MichaelRocks/paranoid/

It seems very similar, and yet there is no mention about it, and no credit... I ask because I'm thinking of migrating away from it, and I think it might be quite easy to do it if it's about the same...

yujincheng08 commented 1 year ago

mentioned in the license

AndroidDeveloperLB commented 1 year ago

@yujincheng08 I don't see it here: https://github.com/LSPosed/LSParanoid#license and not here: https://github.com/LSPosed/LSParanoid/blob/master/LICENSE.txt

No mention of the original repository, but there is a mention of "Michael Rozumyanskiy" who made it. Can you please mention that it's based on it?

yujincheng08 commented 1 year ago

Does apache 2.0 require mentioning the original repository? Following Apache 2.0, I kept the original license and author. I also kept all the historical commits.

AndroidDeveloperLB commented 1 year ago

No, but it's nice, and I wanted to see if migration would be easy

yujincheng08 commented 1 year ago

Basically, I think license applies to all sources, and it's a better way to credit the original author. But as you required, I added credits to the Readme. Thanks you anyway.

AndroidDeveloperLB commented 1 year ago

Thank you!