LSPosed / MagiskOnWSALocal

Integrate Magisk root and Google Apps into WSA (Windows Subsystem for Android)
GNU Affero General Public License v3.0
9.49k stars 22.97k forks source link

[Bug] Unable to install on standard user account. #276

Closed oneironaut2209 closed 1 year ago

oneironaut2209 commented 1 year ago

Steps to reproduce/复现步骤

  1. Login standard user account.
  2. Run Run.bat
  3. Grant Administrative permissions.
  4. It will throw an error

Expected behaviour/预期行为

Should open WSA app

Actual behaviour/实际行为

Gives error. See screenshot below. It works fine on admin logged account.

MagiskOnWSALocal commit full SHA/MagiskOnWSALocal 提交的完整哈希

78a408de0ce9d576323cd9c8e9c8e8d72b59cc2d

Linux distribution info/Linux 发行版信息

Ubuntu 22.04.1 LTS

Windows version/Windows 版本

22000.1281

Build Parameters/构建参数

INFO: Architecture: x64 INFO: Release Type: retail INFO: Magisk Version: stable INFO: GApps Brand: MindTheGapps INFO: GApps Variant: pico INFO: Root Solution: magisk Build: RELEASE_TYPE=Retail

Version requirement/版本要求

Logs/日志

image

Howard20181 commented 1 year ago

Please install in admin accout

rom4ster commented 1 year ago

Why is this not planned? Installing as an admin makes it so that it is impossible to use this without logging in as an administrator.

I cannot run any WSA through an elevated shell as it requires an interactive session

Running an admin shell will not work. It is good security practice and frankly a normal part of windows to use a non admin account for daily driving. Please resolve this issue. I can install WSA through windows store on my non admin account so the issue is in this installer or app package.

Discriminating against users with security practices is never a good look for any piece of software so please re open this and fix

zamarax commented 1 year ago

Honestly, I have to agree here as well, it's terribly bad practice.

__ Regards, Corey Zamara

On Fri, 31 Mar 2023 at 10:53, rom4ster @.***> wrote:

Why is this not planned? Installing as an admin makes it so that it is impossible to use this without logging in as an administrator.

I cannot run any WSA through an elevated shell as it requires an interactive session

Running an admin shell will not work. It is good security practice and frankly a normal part of windows to use a non admin account for daily driving. Please resolve this issue. I can install WSA through windows store on my non admin account so the issue is in this installer or app package.

Discriminating against users with security practices is never a good look for any piece of software so please re open this and fix

— Reply to this email directly, view it on GitHub https://github.com/LSPosed/MagiskOnWSALocal/issues/276#issuecomment-1492053620, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGDQXMCLPBOTWODYRDRLS53W63VYDANCNFSM6AAAAAASWKENEM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Howard20181 commented 1 year ago

There is no possibility to install without administrator privileges

  1. If you install the unpacked MSIX package, you must install it in developer mode, which requires that it must be done with administrator privileges
  2. If you want to install packaged WSA, which must be unmodified, then it is not possible to integrate Magisk.
  3. if you want to repackage after integrating Magisk, you must sign the installation package, applying for a valid signature requires a paid application as a company, if not applying for a signature, self-signed installation packages using development signatures require sideloading in developer mode, which goes back to point 1
rom4ster commented 1 year ago

YOu should make a signed install option, since its all unpacked anyways, and let the user provide the certificate. That is still better practice than just disabling the option all together.

Howard20181 commented 1 year ago

If a packaged version is provided it must use our own signature, no customization is allowed. You need to manually install and trust the root certificate issued by us. This will only start to be implemented if it is acceptable to most people.