search

LSPosed / MagiskOnWSALocal

Integrate Magisk root and Google Apps into WSA (Windows Subsystem for Android)
GNU Affero General Public License v3.0
9.6k stars 23.13k forks source link

List dependencies required #74

Closed soda3x closed 2 years ago

soda3x commented 2 years ago

I'm not sure if the run script is supposed to collect the dependencies or not, but on WSL it didn't for me so I ran the install script multiple times with it stopping and complaining about missing deps and me grabbing said deps and getting closer and closer to it working each time.

Could this be added to the script? In my case I needed to manually install wine, winetricks, lzip, aria2 and patchelf

Howard20181 commented 2 years ago

In turn, it was added long ago. https://github.com/LSPosed/MagiskOnWSALocal/blob/70bb0fdb8f7c9f5c47baee636309641302d480cc/scripts/run.sh#L52 https://github.com/LSPosed/MagiskOnWSALocal/blob/dca2264212fc25adb6f0a69445d484d62c7ed098/scripts/run.sh#L41-L47

soda3x commented 2 years ago

hmm odd, it certainly didn't install those

Howard20181 commented 2 years ago

Maybe your system's package manager is not apt or the repository is old. Other package managers were not supported before and are not officially supported now. I'm not very familiar with package managers other than apt, so auto-install is disabled by default. https://github.com/LSPosed/MagiskOnWSALocal/blob/dca2264212fc25adb6f0a69445d484d62c7ed098/scripts/run.sh#L50-L72

soda3x commented 2 years ago

WSL2 with Ubuntu, so using APT with a fresh clone

Howard20181 commented 2 years ago

Same as you, Ubuntu 20.04 and 22.04 are working fine