LSPosed / MagiskOnWSALocal

Integrate Magisk root and Google Apps into WSA (Windows Subsystem for Android)
GNU Affero General Public License v3.0
9.41k stars 22.86k forks source link

install_deps: upgrade only specified packages, not full system #768

Closed theblackhole closed 5 months ago

theblackhole commented 6 months ago

Change install_deps.sh script behaviour especially for Debian-based systems to only upgrade specified packages instead of all installed packages. (e.g. apt-get install -y ca-certificates instead of apt-get upgrade -y ca-certificates where ca-certificates is ignored and a full system upgrade is launched)

A full system upgrade is not necessary because the package manager handle dependencies/libraries upgrade automatically when you install/upgrade packages.

A full system upgrade can even be dangerous/unwanted on some cases, especially because of the -y option used here (e.g. a pending display driver update that could break everything with the next reboot).

However, if ever in the future there is a real need for a complete system upgrade, the upgrade commands have been moved to a new PM_SYSTEM_UPGRADE_MAP array (with its related SYSTEM_UPGRADE_OPTION), this time without the -y argument to let the user check and confirm the proposed updates.

Checklist