LSPosed / MagiskOnWSALocal

Integrate Magisk root and Google Apps into WSA (Windows Subsystem for Android)
GNU Affero General Public License v3.0
9.57k stars 23.09k forks source link

[Bug] No question on installing Gapps when choosing no root #811

Closed OctoCharm closed 2 months ago

OctoCharm commented 2 months ago

Steps to reproduce/复现步骤

  1. Run ./scripts/run.sh
  2. Selected build arch: x64
  3. Selected WSA release type: retail
  4. Do you want to root WSA? No
  5. Do you want to remove Amazon Appstore? Yes
  6. Do you want to compress the output? No

Expected behaviour/预期行为

There should be a question of whether I want to install Gapps when I'm choosing a non-root solution.

Actual behaviour/实际行为

There's no question about whether I want to install Gapps when I'm choosing a non-root solution.

MagiskOnWSALocal commit full SHA/MagiskOnWSALocal 提交的完整哈希

599e02705417298f8f99b5d773fe92157bb7dd32

Linux distribution info/Linux 发行版信息

PRETTY_NAME="Ubuntu 22.04.4 LTS" NAME="Ubuntu" VERSION_ID="22.04" VERSION="22.04.4 LTS (Jammy Jellyfish)" VERSION_CODENAME=jammy ID=ubuntu ID_LIKE=debian HOME_URL="https://www.ubuntu.com/" SUPPORT_URL="https://help.ubuntu.com/" BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/" PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy" UBUNTU_CODENAME=jammy

Windows version/Windows 版本

26100.1150

Build Parameters/构建参数

COMMAND_LINE=--arch x64 --release-type retail --remove-amazon INFO: Architecture: x64 INFO: Release Type: retail INFO: Magisk Version: stable INFO: Root Solution: magisk INFO: Compress Format: none INFO: Release Name: Retail

Version requirement/版本要求

Logs/日志

[//]: <> (Don't modify above) ``` COMMAND_LINE=--arch x64 --release-type retail --remove-amazon INFO: Architecture: x64 INFO: Release Type: retail INFO: Magisk Version: stable INFO: Root Solution: magisk INFO: Compress Format: none INFO: Release Name: Retail Generating WSA Download Links Generating WSA download link: arch=x64 release_type=Retail WSA Build Version=2407.40000.0.0 download link: http://tlu.dl.delivery.mp.microsoft.com/filestreamingservice/files/251bbb12-dbfc-4820-b0ff-c4dfa70ffb09?P1=1723638302&P2=404&P3=2&P4=K6CgWLTSuSMZbW5Riw4ck1%2bES2ffX7haoIBpGiyGTUmGaABwMqd6CTz4yyO01F%2bzFGiuollHasWBL5C65ns53g%3d%3d path: ../download/Microsoft.UI.Xaml.2.8_x64.appx download link: http://tlu.dl.delivery.mp.microsoft.com/filestreamingservice/files/27ca12bc-f81d-45ff-95d0-12ad79f15735?P1=1723638359&P2=404&P3=2&P4=Jf%2fF3zpV1SS5xmhlp5klSFFfQDL9%2f5Jw2mneyYqjNGEoJdQQD%2f35Vo5BFmLNx7xkfXGfq83yM0LhCxDWdYxEEA%3d%3d path: ../download/Microsoft.VCLibs.140.00.UWPDesktop_x64.appx download link: http://tlu.dl.delivery.mp.microsoft.com/filestreamingservice/files/c452d4ef-2486-4efe-9c99-36b3d23e0160?P1=1723638278&P2=404&P3=2&P4=EMnlm%2fBiYgq5jilao4TvKAZAUEfLqZFWvOpPsAzmhKDLLDdTJFwtAvGqE3Cq28tRUyvvhFc5XdvU9r%2fTnYI6eA%3d%3d path: ../download/Microsoft.VCLibs.140.00_x64.appx download link: http://tlu.dl.delivery.mp.microsoft.com/filestreamingservice/files/b997a699-594b-43db-ac2e-19a4c45b6af2?P1=1723666021&P2=404&P3=2&P4=aFU5fENwTdwJ9TivyzRuMnbE4gV9N0v%2btEJeyikLxdxSW313YiswHxiNMG71dg4iFooV8Y5xc43SVPoQfK2CzQ%3d%3d path: ../download/wsa-retail.zip Downloading WSA 08/14 12:14:28 [NOTICE] Downloading 4 item(s) 08/14 12:14:28 [NOTICE] GID#0eb40ce8c5d07c45 - Download has already completed: ../download/Microsoft.UI.Xaml.2.8_x64.appx 08/14 12:14:28 [NOTICE] Download complete: ../download/Microsoft.UI.Xaml.2.8_x64.appx 08/14 12:14:28 [NOTICE] GID#9219c9cf6b3fbc48 - Download has already completed: ../download/wsa-retail.zip 08/14 12:14:28 [NOTICE] Download complete: ../download/wsa-retail.zip 08/14 12:14:28 [NOTICE] GID#6c230976eb754e8d - Download has already completed: ../download/Microsoft.VCLibs.140.00_x64.appx 08/14 12:14:28 [NOTICE] Download complete: ../download/Microsoft.VCLibs.140.00_x64.appx 08/14 12:14:28 [NOTICE] GID#90ee0c49fcee9480 - Download has already completed: ../download/Microsoft.VCLibs.140.00.UWPDesktop_x64.appx 08/14 12:14:28 [NOTICE] Download complete: ../download/Microsoft.VCLibs.140.00.UWPDesktop_x64.appx Download Results: gid |stat|avg speed |path/URI ======+====+===========+======================================================= 0eb40c|OK | 0B/s|../download/Microsoft.UI.Xaml.2.8_x64.appx 9219c9|OK | 0B/s|../download/wsa-retail.zip 6c2309|OK | 0B/s|../download/Microsoft.VCLibs.140.00_x64.appx 90ee0c|OK | 0B/s|../download/Microsoft.VCLibs.140.00.UWPDesktop_x64.appx Status Legend: (OK):download completed. Extracting WSA unzipping WsaPackage_2407.40000.0.0_x64_Release-Nightly.msix to /tmp/wsa-build-13i6K5tMrO_/wsa unzipping from /tmp/wsa-build-13i6K5tMrO_/wsa/WsaPackage_2407.40000.0.0_x64_Release-Nightly.msix done Generating Download Links Generating Magisk download link: release type=stable download link: https://github.com/topjohnwu/Magisk/releases/download/v27.0/Magisk-v27.0.apk path: ../download/magisk-stable.zip download link: https://github.com/LSPosed/WSA-Addon/releases/download/v1/cust.img path: ../download/cust.img Downloading Artifacts 08/14 12:14:40 [NOTICE] Downloading 2 item(s) 08/14 12:14:40 [NOTICE] CUID#8 - Redirecting to https://objects.githubusercontent.com/github-production-release-asset-2e65be/766310164/3f0bf1f1-ccfe-42d1-9aff-5228bf00116d?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=releaseassetproduction%2F20240814%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20240814T121440Z&X-Amz-Expires=300&X-Amz-Signature=d38e090117d841e058215860f0b527bf66d2aa57dc6ad109078567f8a6803a52&X-Amz-SignedHeaders=host&actor_id=0&key_id=0&repo_id=766310164&response-content-disposition=attachment%3B%20filename%3Dcust.img&response-content-type=application%2Foctet-stream 08/14 12:14:40 [NOTICE] CUID#7 - Redirecting to https://objects.githubusercontent.com/github-production-release-asset-2e65be/67702184/7863ce3c-c7a4-4245-a059-123004ca4806?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=releaseassetproduction%2F20240814%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20240814T121440Z&X-Amz-Expires=300&X-Amz-Signature=bae8334c521d10600e33f60a237825d09fc01e9bd12921f8de5ab1091c5f26de&X-Amz-SignedHeaders=host&actor_id=0&key_id=0&repo_id=67702184&response-content-disposition=attachment%3B%20filename%3DMagisk-v27.0.apk&response-content-type=application%2Fvnd.android.package-archive 08/14 12:14:40 [NOTICE] GID#8ce4039bc2acd8f7 - Download has already completed: ../download/magisk-stable.zip 08/14 12:14:40 [NOTICE] Download complete: ../download/magisk-stable.zip 08/14 12:14:40 [NOTICE] GID#9bd85b2eb1b52d7c - Download has already completed: ../download/cust.img 08/14 12:14:40 [NOTICE] Download complete: ../download/cust.img Download Results: gid |stat|avg speed |path/URI ======+====+===========+======================================================= 8ce403|OK | 0B/s|../download/magisk-stable.zip 9bd85b|OK | 0B/s|../download/cust.img Status Legend: (OK):download completed. Extracting Magisk Magisk version: 27.0 (27000) done Integrating Magisk Loading cpio: [/tmp/wsa-build-13i6K5tMrO_/wsa/x64/Tools/initrd.img] Move [/init] -> [/wsainit] Add file [/lspinit] (100750) Create symlink [/init] -> [/lspinit] Add file [/magiskinit] (100750) Create directory [overlay.d] (0750) Create directory [overlay.d/sbin] (0750) Add file [overlay.d/sbin/magisk64.xz] (100644) Add file [overlay.d/sbin/magisk32.xz] (100644) Add file [overlay.d/sbin/stub.xz] (100644) Create directory [.backup] (0000) Add file [overlay.d/init.lsp.magisk.rc] (100000) Add file [overlay.d/sbin/post-fs-data.sh] (100000) Add file [overlay.d/sbin/lsp_cust.img] (100000) Dumping cpio: [/tmp/wsa-build-13i6K5tMrO_/wsa/x64/Tools/initrd.img] done Removing signature and add scripts done Copying to ../output/WSA_2407.40000.0.0_x64_Release-Nightly-with-magisk-27.0(27000)-stable-NoGApps-NoAmazon ``` [//]: <> (Don't modify below)