[Bug] Integrates Magisk even if selecting "No" to root question. - Githubissues

LSPosed / MagiskOnWSALocal

Integrate Magisk root and Google Apps into WSA (Windows Subsystem for Android)

GNU Affero General Public License v3.0

9.6k stars 23.12k forks source link

[Bug] Integrates Magisk even if selecting "No" to root question. #817

Closed StormProductionsMusic closed 2 weeks ago

StormProductionsMusic commented 3 weeks ago

Steps to reproduce/复现步骤

Run run.sh;
Select "No" to the root question;
In the output directory, the filename wll still mention "with-magisk" even though rooting was set to no.

Expected behaviour/预期行为

WSA should compile without Magisk

Actual behaviour/实际行为

Instead it generates with Magisk even though "No" was selected.

MagiskOnWSALocal commit full SHA/MagiskOnWSALocal 提交的完整哈希

I used git clone, don't know where to look for such info. Cloned just 30 minutes before posting this issue.

Linux distribution info/Linux 发行版信息

Ubuntu 22.04

Windows version/Windows 版本

Windows Insider build 27729.1000

Build Parameters/构建参数

-

Version requirement/版本要求

[X] I am using latest commit of MagiskOnWSALocal/我正在使用最新 commit 的版本

Logs/日志

[//]: <> (Don't modify above) ``` # Replace this line with the log / 将此行用日志替换 ``` [//]: <> (Don't modify below)