search

LSS-Manager / LSSM-V.4

The Official Repository for LSS Manager V4
https://lss-manager.de
Other
54 stars 91 forks source link

[BUG]: HazMat personnel not properly counted in extended missing vehicle table. #2052

Closed JanSuerth closed 3 months ago

JanSuerth commented 1 year ago

What happened?

On the US Version the missing-vehicles alert displays missing Hazmat personnel. When "Enhanced missing vehicles" from the "Extended alarm window" module is enabled the personnel also gets displayed in the table.

When selecting a vehicle the counter for the educated hazmat personnel doesn't count people on the vehicle but rather only the hazmat vehicle (so the counter goes up by one even when "maximum staff" is enabled)

Vehicles like the Hazmat Ambulance do not get counted at all for the personnel.

Default display: https://i.imgur.com/TU5K78s.png With enhanced missing vehicles: https://i.imgur.com/qXprl1N.png (In both pictures there is a HazMat ambulance selected but not yet dispatched. It is staffed with 6 educated personnel and "maximum staff" is enabled for enhanced missing vehicles.

How to reproduce?

  1. extended missing vehicles needs to be enabled
  2. maximum staff needs to be enabled
  3. in a mission with missing hazmat personnel select a HazMat or HazMat ambulance

Expected behavior

I expected that the personnel of the HazMat or HazMat ambulance would be counted towards the missing personnel rather then counting the number of Hazmat vehicles selected.

System

Additional

msedge_m8DvenHE7D tnxv0UHZTo

Cr4zyc4k3 commented 1 year ago

@jxn-30 This should be fixable with a few tweaks in https://github.com/LSS-Manager/LSSM-V.4/blob/1d360ca05e9f370a37a7cfeb663bfcf99ee14c52/src/modules/extendedCallWindow/i18n/en_US.json#L91 or did I miss something?

jxn-30 commented 1 year ago

@jxn-30 This should be fixable with a few tweaks in https://github.com/LSS-Manager/LSSM-V.4/blob/1d360ca05e9f370a37a7cfeb663bfcf99ee14c52/src/modules/extendedCallWindow/i18n/en_US.json#L91 or did I miss something?

I don't think so. The parser will still count the text as a vehicle (there is no fully reliable way to determine for a text if it is a vehicle or a training requirement). As the texts are exactly same for HazMat vehicle and training requirement, the issue is caused.

Cr4zyc4k3 commented 7 months ago

Next try: With https://forum.leitstellenspiel.de/index.php?thread/8406-infos-f%C3%BCr-entwickler/&postID=495288#post495288 we should be able to distinguish between personal, vehicles and "others"

Cr4zyc4k3 commented 5 months ago

@JanSuerth Is this fixed now?