LSS-Manager / LSSM-V.4

The Official Repository for LSS Manager V4
https://lss-manager.de
Other
54 stars 91 forks source link

[BUG]: [Chatextras] Icons and username disappear after activation #214

Closed Suchty112 closed 3 years ago

Suchty112 commented 3 years ago

Describe what happens the @ and /w symbol and username have been removed by activating chat extras

How to reproduce? Activate the new addon chatextras

Expected behavior What did you expect LSS-Manager to do?

Screenshots blob blob Further notes: (please complete)

Further Add further notes here

JRH-1997 commented 3 years ago

Also the username is removed

JRH-1997 commented 3 years ago

A possible solution: Change: messageHeader.innerText = '[' + timeStampModified + ']'; to: messageHeader.firstChild.textContent = '[' + timeStampModified + '] ';

Don't forget the spaces for the space between date and first icon afbeelding

JRH-1997 commented 3 years ago

Also new messages aren't edited afbeelding

jxn-30 commented 3 years ago

For new messages, date instead of date_hidden needs to be modified. For existing chatMessages, we could get the textNode which is [XX:XX] and modify that one. Should be the easiest way to do that. A way to get all TextNodes within a specific element can be found in /src/utils.ts. The generalExtensions' setting "clickableLinks" makes use of such a function. We just need to adjust that one to make recursive node finding optional :)

Cr4zyc4k3 commented 3 years ago

Should be fixed with https://github.com/LSS-Manager/LSSM-V.4/commit/e904775918d94376782901b4a94f9fd8470bbfb1

jxn-30 commented 3 years ago

Done with #220 if further issues are detected, reopen or create new issue!