LSS-Manager / LSSM-V.4

The Official Repository for LSS Manager V4
https://lss-manager.de
Other
54 stars 91 forks source link

[BUG] Extended alarm window: Temporary mission gone from interface, still in .lssm file #414

Closed CrustaShrimp closed 3 years ago

CrustaShrimp commented 3 years ago

Describe what happens In the Dutch version of the game, there are temporary mission types, usually seasonal (Christmas, New Years, Easter etc.) After adding those mission types to the "Meldingstrefwoord" (part of the Extended alarm window), the correct labels show up. However, the settings page in LSSM only allows mission types that are in the active JSON to be selected, the rest cannot be chosen. Hence, after the mission types are deleted from the JSON, they cannot be seen in the settings anymore. When you export the settings however, the mission types IDs are still there

How to reproduce? Explain here what you did when the error occured for example:

  1. Add temporary misison to the Extended alarm window
  2. Export the LSSM settings and verify the mission ID is stored in the correct label
  3. Wait for the mission type to be deleted from the JSON, mission type is no longer available
  4. Check the LSSM settings, note that the mission ID is gone from the list
  5. Export the LSSM settings and see the mission ID still there

Expected behavior Either remove the ID from the exported settings, or keep showing it in the online settings menu, with a placeholder name like "Mission not available"

Screenshots Example: mission ID 169 has been removed from the JSON. It does not show up in the online settings, but when exporting them, it is still in the LSSM file.

Online settings: image

Exported settings: image

Further notes: (please complete)

Further

JRH-1997 commented 3 years ago

@jxn-30 I think this one is solved by the update of the API?