search

LSST-nonproject / sims_maf_contrib

Contributed code for MAF (sims_maf)
18 stars 46 forks source link

Galaxy counts #13

Closed rhiannonlynne closed 9 years ago

rhiannonlynne commented 9 years ago

Might as well see what code review looks like on github.

yoachim commented 9 years ago

hmm, there's no handy "Approve" button like Stash. Am I just supposed to comment "Approved", or should I close the pull request as well?

rhiannonlynne commented 9 years ago

I think when we're "done", we are supposed to add a milestone or something? Or maybe I was supposed to open an associated issue? Hmm, not sure. Saying it's done is fine for me for now. I guess not closing the branch is good, since there are small issues to update.

drphilmarshall commented 9 years ago

I was just about to suggest you merge this. If there are remaining small issues, you should start an issue on each of them! Milestones are things you define in advance, so you can assign issues to them: when all of a milestone's issues are closed, and you have no more to make, you can close the milestone. They're for keeping projects on track. A good system for milestones is to figure out what your next delivery date is, and make a milestone for that. The next cadence workshop should definitely be a milestone, but there's probably going to be some before that. Any sort of release coming up?

On Tue, Feb 17, 2015 at 5:22 PM, Lynne Jones notifications@github.com wrote:

Merged #13 https://github.com/LSST-nonproject/sims_maf_contrib/pull/13.

— Reply to this email directly or view it on GitHub https://github.com/LSST-nonproject/sims_maf_contrib/pull/13#event-237382843 .