search

LSST-nonproject / sims_maf_contrib

Contributed code for MAF (sims_maf)
18 stars 46 forks source link

Grb science #38

Closed ebellm closed 7 years ago

ebellm commented 8 years ago

improved version of GRBTransientMetric and associated notebook.

rhiannonlynne commented 8 years ago

Looks good. If you want to stop producing the power spectrum plots (I'm not sure they're terribly useful to you?), you can add the following:

import lsst.sims.maf.plots as plots

plotFuncs = [plots.HealpixSkyMap(), plots.HealpixHistogram()]

before you define the metric bundles, and then when setting the metric bundles, add plotFuncs=plotFuncs as one of the keyword arguments.

ebellm commented 8 years ago

Thanks! I added the __all__ back in--I deleted it accidentally, it looks like. The plotFuncs didn't seem to work in this case--perhaps because I'm reducing over multiple filters?

rhiannonlynne commented 8 years ago

Hmm. Nope, that's actually a little bug in MAF that we hadn't noticed before. The plotFuncs are not passed along to the reduce functions, although they should be. Thanks for finding it! If you leave the plotFuncs there, they shouldn't hurt anything currently and will work with the next release of MAF.

On Mon, Apr 25, 2016 at 9:55 PM Eric Bellm notifications@github.com wrote:

Thanks! I added the all back in--I think it got deleted casually. The plotFuncs didn't seem to work in this case--perhaps because I'm reducing over multiple filters?

— You are receiving this because you commented.

Reply to this email directly or view it on GitHub https://github.com/LSST-nonproject/sims_maf_contrib/pull/38#issuecomment-214616317