search

LSST-nonproject / sims_maf_contrib

Contributed code for MAF (sims_maf)
18 stars 46 forks source link

U/lynnej/update depth limited num gal metric #79

Closed rhiannonlynne closed 3 years ago

rhiannonlynne commented 4 years ago

Swapped DepthLimitedNumGal to use ExgalM5_with_cuts ( from MAF) instead of egFootprint. This should make it run slightly faster, but it also consolidates the calculation of the restricted footprint to one location/one piece of code.

rhiannonlynne commented 4 years ago

@humnaawan would you mind please having a look at the changes here to make sure that this doesn't break anything you need? It will also require either this branch of MAF to run: https://github.com/lsst/sims_maf/tree/u/lynnej/addDESCWFD (u/lynnej/addDESCWFD) or for that branch to have been merged to master (but this has not been done yet) and then a new version of MAF used, so that ExgalM5_with_cuts is available as a metric.

rhiannonlynne commented 3 years ago

Coming back to this - the metric results don't change, just how they're calculated is consolidated to one place (for the footprint). Trying to clean stuff up, so I'm going to go ahead and merge this before it gets too out of date with master.

rhiannonlynne commented 3 years ago

Deleted branch https://github.com/LSST-nonproject/sims_maf_contrib/tree/u/lynnej/update_depthLimitedNumGalMetric